After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745442 - glsl, gles2: Type mismatch in arithmetic operation between 'int' and 'float'
glsl, gles2: Type mismatch in arithmetic operation between 'int' and 'float'
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2015-03-02 10:58 UTC by Alban Browaeys
Modified: 2016-09-19 14:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix implicit cast int to float to cope with gles2 glsl. (1.46 KB, patch)
2015-03-02 10:58 UTC, Alban Browaeys 		committed Details | Review

Description Alban Browaeys 2015-03-02 10:58:13 UTC 
Created attachment 298268 [details] [review]
Fix implicit cast int to float to cope with gles2 glsl.

gles2 glsl complains thus way when I get to the overview mode of gnome-shell (mali 400 r1p1 gpu with r5p0 userpace blob):

(gnome-shell:8954): Cogl-WARNING **: Shader compilation failed:
1:2: P0004: High precision not supported, instead compiling high precision as medium precision
4:17: S0001: Type mismatch in arithmetic operation between 'int' and 'float'

The attach fix replace the "1 - <float>"  by "1.0 - <float>" .

The issue was showcased under debian mutter 3.14.2 so this affect previous releases too.
Comment 1 Matthias Clasen 2015-03-02 17:58:20 UTC 
might be worth backporting to 3.14
Comment 2 drago01 2015-03-03 21:08:51 UTC 
Review of attachment 298268 [details] [review]:

Looks good.
Comment 3 drago01 2015-03-03 21:11:15 UTC 
Pushed to master and cherrypicked into 3.14
Comment 4 Debarshi Ray 2016-09-19 14:11:53 UTC 
Comment on attachment 298268 [details] [review]
Fix implicit cast int to float to cope with gles2 glsl.

Update the patch status.