After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745393 - World clocks buttons seem not accessible in the calendar/notication area
World clocks buttons seem not accessible in the calendar/notication area
Status: RESOLVED OBSOLETE
Product: gnome-shell
Classification: Core
Component: calendar
3.15.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2015-03-01 23:27 UTC by Juanjo Marín
Modified: 2021-07-05 14:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
dateMenu: Set label_actor for WorldClock button (1.09 KB, patch)
2015-03-03 22:25 UTC, Florian Müllner
committed Details | Review

Description Juanjo Marín 2015-03-01 23:27:57 UTC
Navigating the new notication area with the screen reader on, the world clock buttons are not read correctly, they are read simply as "Push Button"
Comment 1 Florian Müllner 2015-03-02 00:39:29 UTC
That's basically because there was no obvious choice for what the accessible name should be - "World Clocks" isn't overly helpful, while reading the full list gets exhaustive as locations are added.
Any guidance here would be greatly appreciated ...
Comment 2 Alejandro Piñeiro Iglesias (IRC: infapi00) 2015-03-02 11:51:59 UTC
(In reply to Florian Müllner from comment #1)
> That's basically because there was no obvious choice for what the accessible
> name should be - "World Clocks" isn't overly helpful, while reading the full
> list gets exhaustive as locations are added.
> Any guidance here would be greatly appreciated ...

Just tested, thanks for pointing the bug.

The problem here is that there is just one element focusable. I guess that that makes sense from the action-user pov, as there is just one action possible: open gnome-clocks. But from the accessible/keyboard navigation pov, I think that it would be better each row of the list being navigable. In that scenario "World Clocks" would be the accessible name of the container area, and the accessible name for each row would be the city+hour.

PS: doing this tests I also found several keyboard navigation bugs on gnome-clocks (bug 745444, bug 745445, bug 745446, bug 745447), and just doing a skimming. So even if this bug get solved, the user would be redirected to a non-accessible application.
Comment 3 Florian Müllner 2015-03-03 22:12:12 UTC
(In reply to Alejandro Piñeiro Iglesias (IRC: infapi00) from comment #2)
> The problem here is that there is just one element focusable. I guess that
> that makes sense from the action-user pov, as there is just one action
> possible: open gnome-clocks. But from the accessible/keyboard navigation
> pov, I think that it would be better each row of the list being navigable.

IMHO it's even trickier, and the current behavior is correct for a11y/keynav as well except for the screen reader/orca case. It also doesn't help that we don't actually have rows we could focus, but cells in a grid :-(

So not sure what to do - short-term it doesn't look too urgent, given the Clocks issues you pointed out. So maybe just set the button's label_actor to the section title ("World Clocks" if some clocks have been configured, "Add world clock ..." otherwise) and leave the bug open for a better long-term option?
Comment 4 Florian Müllner 2015-03-03 22:25:41 UTC
Created attachment 298488 [details] [review]
dateMenu: Set label_actor for WorldClock button

Ideally we would allow navigating into the button in the screen
reader case, so the configured clocks are read out properly.
However we can still do better than nothing short-term by pointing
to the section header as the button's label_actor.
Comment 5 Alejandro Piñeiro Iglesias (IRC: infapi00) 2015-03-04 10:10:17 UTC
(In reply to Florian Müllner from comment #3)
> (In reply to Alejandro Piñeiro Iglesias (IRC: infapi00) from comment #2)
> > The problem here is that there is just one element focusable. I guess that
> > that makes sense from the action-user pov, as there is just one action
> > possible: open gnome-clocks. But from the accessible/keyboard navigation
> > pov, I think that it would be better each row of the list being navigable.
> 
> IMHO it's even trickier, and the current behavior is correct for a11y/keynav
> as well except for the screen reader/orca case. It also doesn't help that we
> don't actually have rows we could focus, but cells in a grid :-(

Just a question, are those cells focusable?

> So not sure what to do - short-term it doesn't look too urgent, given the
> Clocks issues you pointed out. So maybe just set the button's label_actor to
> the section title ("World Clocks" if some clocks have been configured, "Add
> world clock ..." otherwise) and leave the bug open for a better long-term
> option?

As the lesser, and if those cells are not focusable, yes, probably this is the lesser short-term evil.
Comment 6 Florian Müllner 2015-03-04 13:05:00 UTC
(In reply to Alejandro Piñeiro Iglesias (IRC: infapi00) from comment #5)
> Just a question, are those cells focusable?

No, and even if they were, they were still inaccessible by keynav as the button they are in would take the focus itself.


> As the lesser, and if those cells are not focusable, yes, probably this is
> the lesser short-term evil.

OK, doing that for now - if we don't want to break pointer use, we'll have to do something custom there to keep the button, but allow navigating inside when insisting hard enough ...
Comment 7 Florian Müllner 2015-03-04 13:05:31 UTC
Comment on attachment 298488 [details] [review]
dateMenu: Set label_actor for WorldClock button

Attachment 298488 [details] pushed as bb2d7f7 - dateMenu: Set label_actor for WorldClock button
Comment 8 GNOME Infrastructure Team 2021-07-05 14:29:55 UTC
GNOME is going to shut down bugzilla.gnome.org in favor of  gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version, then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a new ticket at
  https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/

Thank you for your understanding and your help.