GNOME Bugzilla – Bug 745298
g-ir-doc-tool: Implement missing features to bring it closer to parity with gtk-doc
Last modified: 2016-09-01 02:17:37 UTC
This also removes some "parsing" code for paragraphs, which is better handled by the actual scanner.
Created attachment 298110 [details] [review] docwriter: parse markdown code.
I also can parse github-flavored code blocks markdown, for it is now pretty standard, and I'd like deprecating these '|[' ']|' markers, because they're uselessly complicated.
Created attachment 298340 [details] [review] docwriter: parse markdown for code blocks. This also removes some "parsing" code for paragraphs, which is better handled by the actual scanner.
Review of attachment 298110 [details] [review]: Obsoleted by the next patch which adds support for languages as specified.
Review of attachment 298340 [details] [review]: Fails "make distcheck": ../giscanner/docwriter.py:37:9: E126 continuation line over-indented for hanging indent ../giscanner/docwriter.py:56:9: E126 continuation line over-indented for hanging indent ../giscanner/docwriter.py:58:1: E302 expected 2 blank lines, found 1 Am a bit short on time so didn't look further than that yet
(In reply to Dieter Verfaillie from comment #5) > Review of attachment 298340 [details] [review] [review]: > > Fails "make distcheck": > ../giscanner/docwriter.py:37:9: E126 continuation line over-indented for > hanging indent > ../giscanner/docwriter.py:56:9: E126 continuation line over-indented for > hanging indent > ../giscanner/docwriter.py:58:1: E302 expected 2 blank lines, found 1 > > Am a bit short on time so didn't look further than that yet This kind of style checks shouldn't be made at make check time but at commit time, I have just copied a commit-hook from another project in gobject-introspection and removed the old code for these checks, and also fixed all the pep8 issues in the commits on my branch, which is @ https://github.com/MathieuDuponchelle/gobject-introspection/commits/markdown_parsing I'll requalify the bug to a tracker bug for all the improvements I make in g-ir-doc-tool, please provide reviews in https://github.com/MathieuDuponchelle/gobject-introspection/pull/1
This branch should really make it in, can we get a maintainer involved here ? :)
I only scanned this branch, but it looks reasonably written and I'd be OK to merge it.
Closing, this is obsolete.