After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745279 - allow to delete notifications using Delete key
allow to delete notifications using Delete key
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: calendar
3.15.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2015-02-27 10:54 UTC by Kamil Páral
Modified: 2015-02-27 16:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
calendar: Allow to dismiss messages with delete (1.61 KB, patch)
2015-02-27 14:14 UTC, Florian Müllner
committed Details | Review

Description Kamil Páral 2015-02-27 10:54:35 UTC
When I open the new notification area in the calendar widget, I can delete individual notifications using the mouse cursor - there's an X icon on mouse over. I can't do the same using the keyboard - Delete keys does nothing. I can use Enter, but that acts on the notification as well.

Please make the Delete key delete the notification. Thanks.

PS: Should this be filed against 'calendar' or 'message-tray' component? I'm a bit confused, now that it has been moved around.

gnome-shell-3.15.90-1.fc22.x86_64
Comment 1 Florian Müllner 2015-02-27 14:14:02 UTC
Created attachment 298089 [details] [review]
calendar: Allow to dismiss messages with delete

Messages can be dismissed using a pointer device by clicking the
close button, there's no reason to not make the same action
available via keyboard as well. Delete looks like an obvious
choice ...
Comment 2 Rui Matos 2015-02-27 15:15:32 UTC
Review of attachment 298089 [details] [review]:

Looks good otherwise if there's a design ack for this

::: js/ui/calendar.js
@@ +1163,3 @@
+        let type = event.type();
+
+        if (type == Clutter.EventType.KEY_PRESS &&

does a key-press-event handler give you anything but KEY_PRESS ?

@@ +1164,3 @@
+
+        if (type == Clutter.EventType.KEY_PRESS &&
+            event.get_key_symbol() == Clutter.KEY_Delete) {

should probably also handle KEY_KP_Delete
Comment 3 Florian Müllner 2015-02-27 15:30:17 UTC
Attachment 298089 [details] pushed as 0023059 - calendar: Allow to dismiss messages with delete

(In reply to Rui Matos from comment #2)
> does a key-press-event handler give you anything but KEY_PRESS ?

Uhm, yeah ...


> should probably also handle KEY_KP_Delete

Good point as well!
Comment 4 Jakub Steiner 2015-02-27 16:15:20 UTC
sounds good