GNOME Bugzilla – Bug 745279
allow to delete notifications using Delete key
Last modified: 2015-02-27 16:15:20 UTC
When I open the new notification area in the calendar widget, I can delete individual notifications using the mouse cursor - there's an X icon on mouse over. I can't do the same using the keyboard - Delete keys does nothing. I can use Enter, but that acts on the notification as well. Please make the Delete key delete the notification. Thanks. PS: Should this be filed against 'calendar' or 'message-tray' component? I'm a bit confused, now that it has been moved around. gnome-shell-3.15.90-1.fc22.x86_64
Created attachment 298089 [details] [review] calendar: Allow to dismiss messages with delete Messages can be dismissed using a pointer device by clicking the close button, there's no reason to not make the same action available via keyboard as well. Delete looks like an obvious choice ...
Review of attachment 298089 [details] [review]: Looks good otherwise if there's a design ack for this ::: js/ui/calendar.js @@ +1163,3 @@ + let type = event.type(); + + if (type == Clutter.EventType.KEY_PRESS && does a key-press-event handler give you anything but KEY_PRESS ? @@ +1164,3 @@ + + if (type == Clutter.EventType.KEY_PRESS && + event.get_key_symbol() == Clutter.KEY_Delete) { should probably also handle KEY_KP_Delete
Attachment 298089 [details] pushed as 0023059 - calendar: Allow to dismiss messages with delete (In reply to Rui Matos from comment #2) > does a key-press-event handler give you anything but KEY_PRESS ? Uhm, yeah ... > should probably also handle KEY_KP_Delete Good point as well!
sounds good