After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745276 - avidemux: remove not needed code
avidemux: remove not needed code
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.4.5
Other Linux
: Normal enhancement
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 745523 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-02-27 08:58 UTC by Jimmy Ohn
Modified: 2015-03-04 09:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
remove not needed code (1.81 KB, patch)
2015-02-27 09:28 UTC, Jimmy Ohn 		committed Details | Review

Description Jimmy Ohn 2015-02-27 08:58:17 UTC 
I cleanup some code in gst_avi_demux_handle_src_query.
In this function, we already check about stream is vbr or not at the upper line.
So, we don't need to check this condition. because stream is not vbr 100% in this case.
Comment 1 Jimmy Ohn 2015-02-27 09:28:06 UTC 
Created attachment 298067 [details] [review]
remove not needed code

remove not needed code
Comment 2 Sebastian Dröge (slomo) 2015-03-04 09:08:37 UTC 
commit 42599eab7658b7fbe844a13310b2771a72ca9c90
Author: Jimmy Ohn <yongjin.ohn@lge.com>
Date:   Fri Feb 27 18:12:09 2015 +0900

    avidemux: remove not needed code
    
    In gst_avi_demux_handle_src_query, there is not needed code.
    We already check about stream is vbr or not at the upper line.
    o, we don't need to check this condition becase stream is not
    vbr 100% in this case.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=745276
Comment 3 Jimmy Ohn 2015-03-04 09:20:00 UTC 
*** Bug 745523 has been marked as a duplicate of this bug. ***