After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745247 - web-extension: Pass the right .pc file to PKG_CHECK_MODULES
web-extension: Pass the right .pc file to PKG_CHECK_MODULES
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-02-26 18:57 UTC by Michael Catanzaro
Modified: 2015-02-27 18:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
web-extension: Pass the right .pc file to PKG_CHECK_MODULES (1.47 KB, patch)
2015-02-26 18:57 UTC, Michael Catanzaro 		accepted-commit_now Details | Review

Description Michael Catanzaro 2015-02-26 18:57:20 UTC 
Debarshi Ray noticed that we're not using webkit2gtk-web-extension-4.0.pc anywhere in our codebase. Indeed we're using webkit2gtk-4.0.pc to compute cflags and libs for the web extension, and it only works because the .pc files have nearly identical contents.
Comment 1 Michael Catanzaro 2015-02-26 18:57:28 UTC 
Created attachment 298022 [details] [review]
web-extension: Pass the right .pc file to PKG_CHECK_MODULES

We're using the UI process .pc file for the web extension, but did not
notice because the contents of the .pc files are identical.
Comment 2 Carlos Garcia Campos 2015-02-27 06:34:56 UTC 
Review of attachment 298022 [details] [review]:

Yes, because the library is the same, there used to be only one .pc file, but we added a specific one for the web extensions because vala bindings needed that (IIRC). Anyway, the patch looks good.
Comment 3 Michael Catanzaro 2015-02-27 18:32:54 UTC 
Attachment 298022 [details] pushed as cda7743 - web-extension: Pass the right .pc file to PKG_CHECK_MODULES