After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745235 - Wrong session type getting used occasionally
Wrong session type getting used occasionally
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2015-02-26 17:46 UTC by Ray Strode [halfline]
Modified: 2015-02-26 18:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
session: move some debug spew around (9.04 KB, patch)
2015-02-26 17:46 UTC, Ray Strode [halfline]
none Details | Review
session: add more debug spew about session type (5.32 KB, patch)
2015-02-26 17:46 UTC, Ray Strode [halfline]
none Details | Review
session: reset session type to default when selecting non-wayland session (2.86 KB, patch)
2015-02-26 17:47 UTC, Ray Strode [halfline]
none Details | Review

Description Ray Strode [halfline] 2015-02-26 17:46:52 UTC
I notice in my journal sometimes the wrong session type is getting applied
to a session.
Comment 1 Ray Strode [halfline] 2015-02-26 17:46:55 UTC
Created attachment 298008 [details] [review]
session: move some debug spew around

We end up printing "looking for session file" a bunch of times
in the log with no indication why.  This commit drops the message
and instead adds messages to the callers.
Comment 2 Ray Strode [halfline] 2015-02-26 17:46:59 UTC
Created attachment 298009 [details] [review]
session: add more debug spew about session type

This should give a clearer picture about what session type
is getting picked when.
Comment 3 Ray Strode [halfline] 2015-02-26 17:47:03 UTC
Created attachment 298010 [details] [review]
session: reset session type to default when selecting non-wayland session

If we select a non-wayland session we need to clear the session type,
or it will linger as a wayland session if it was one previously.

Prevents users from getting logged into an X session when with
XDG_SESSION_TYPE=wayland.
Comment 4 Ray Strode [halfline] 2015-02-26 18:31:56 UTC
Attachment 298008 [details] pushed as a2b9812 - session: move some debug spew around
Attachment 298009 [details] pushed as 7241f8b - session: add more debug spew about session type
Attachment 298010 [details] pushed as 4e68490 - session: reset session type to default when selecting non-wayland session