GNOME Bugzilla – Bug 745172
Handle inability to load unsupported e-book formats
Last modified: 2015-03-25 13:50:54 UTC
.
Created attachment 297906 [details] [review] books: Hide unsupported book types As we do not have a viewer for ePub books yet, don't show them in the UI.
Review of attachment 297906 [details] [review]: What about all the other non-ePub formats that you removed? If they're also not viewable yet, consider this a-c-n.
(In reply to Cosimo Cecchi from comment #2) > Review of attachment 297906 [details] [review] [review]: > > What about all the other non-ePub formats that you removed? > If they're also not viewable yet, consider this a-c-n. None of them can be viewed yet. I would personally have preferred still showing the items, because it's a book manager, even if we couldn't play them, in the same way that Music or Videos might show videos that cannot be played. Allan?
Review of attachment 297906 [details] [review]: I created an early gnome-3-16 branch for this, so that we don't get into a revert epubs / unrevert epubs cycle in master. So please push to it if you end up removing these. ::: src/search.js @@ -214,3 @@ - name: _("e-Books"), - filter: '(nie:mimeType(?urn) IN (\"application/epub+zip\", \"application/x-mobipocket-ebook\", \"application/x-fictionbook+xml\", \"application/x-zip-compressed-fb2\"))', - where: '?urn rdf:type nfo:EBook .' })); You will also need to remove EBOOKS from getDocumentTypes.
Created attachment 297961 [details] [review] books: Hide unsupported book types As we do not have a viewer for ePub books yet, don't show them in the UI.
(In reply to Bastien Nocera from comment #3) ... > None of them can be viewed yet. I would personally have preferred still > showing the items, because it's a book manager, even if we couldn't play > them, in the same way that Music or Videos might show videos that cannot be > played. > > Allan? I'm not entirely sure about this being comparable to Music [1], but I agree that it's a bit odd to have a Books app that doesn't show any books in it. :) Since I assume that 3.16 is going to be billed as a preview, it might even be nice to show a hint when someone tries to view a book: "You are currently using a preview of Books. Full viewing capabilities are coming soon!" Or something like that. [1] Non-playable music is generally due to codecs, which is an idea that people are used to. The same isn't true for Books.
(In reply to Allan Day from comment #6) > I'm not entirely sure about this being comparable to Music You can still get a music player to somehow play the file if you install the codec. In this case, the code simply does not exist anywhere. > it's a bit odd to have a Books app that doesn't show any books in it It can still show comic book archives in its current form.
(In reply to Debarshi Ray from comment #7) ... > > I'm not entirely sure about this being comparable to Music > > You can still get a music player to somehow play the file if you install the > codec. In this case, the code simply does not exist anywhere. Right, I think that's the point I was trying to make. > > it's a bit odd to have a Books app that doesn't show any books in it > > It can still show comic book archives in its current form. Yes, but given that ePub is the most commonly associated format with books, it would be odd not to show them. There will be a lot of cases where people have ePubs but not comics.
I would be fine keeping the ePub files in the view for 3.16, and add a dialog or a page with a message like Allan proposed, if we're not too late for that now.
Created attachment 298284 [details] [review] documents: Fix spinner starting after an error In some circumstances, such as the PDF loading throwing an error during the load() call, the error signal could be received before "load-started" is, starting the spinner even though we can't make any progress.
Created attachment 298285 [details] [review] books: Show a warning when trying to load e-Books e-Books cannot be previewed yet, but will be in the future. When trying to load an ePub, MOBI, etc. book, throw an error saying: You are currently using a preview of Books. Full viewing capabilities are coming soon!
Review of attachment 298284 [details] [review]: Looks good to me. Thanks, Bastien.
Created attachment 298719 [details] [review] preview: Remove unused variable
Created attachment 298720 [details] [review] view, errorBox: Split ErrorBox into its own file
Created attachment 298721 [details] [review] preview: Restore the ability to handle load-error
Created attachment 298722 [details] [review] books: Show a warning when trying to load e-Books
These patches introduce this new string: "You are using a preview of Books. Full viewing capabilities are coming soon!"
Created attachment 298723 [details] Screenshot
> "You are using a preview of Books. Full viewing capabilities are coming > soon!" Is it helpful to tell me something about "full viewing capabilities" when the very same dialog also says "unable to load file" and rather makes me want to know why the application cannot load that file? File not found? File somehow broken? DRM restrictions? What do I know? (If you want to imply that some formats are not supported yet by the software, you might want to make that crystal clear, apart from optimistic phrasing?)
From #gnome-hackers on GIMPNet: 13:25 <andre> I'd say too late now to break strings for 3.16 so I'd keep the strings as is 13:25 <andre> (and also too unimportant)
Reassigning to new default assignee.