GNOME Bugzilla – Bug 745149
Unclear language in gschema strings
Last modified: 2015-02-26 12:52:47 UTC
In /data/org.gnome.chess.gschema.xml: "Seconds white has used until last move (0 for first move)" "Seconds black has used until last move (0 for first move)" Here it is not clear to me if it is "last move" as in the previous move, or "last move" as in the last (=end) move of the game. Below are the two possible interpretations I can think of: If it is the time passed since the previous move that is meant, it could be made more clear by changing to "Seconds white has used since last move (0 for first move)". If it instead is time left for the player that is meant, it could say "Seconds white has left until last move (0 for first move)". Strings introduced in https://git.gnome.org/browse/gnome-chess/commit/?id=d00db10c103617fa3d864366eb335624b05ac559 Regards, Anders Jonsson
Hi Anders, It actually means the seconds X has used until X's previous move. Suppose game started --- with white and black having(Time Limit) 600 seconds each white took 5 seconds to play its first move black took 30 seconds to play its first move - Now its white's turn again so, White's turn again, now this value(white-last-move-seconds) is "5" - Let me know of your preference for this string, I'll discuss this on IRC today and improve it by EOD.
OK, then I understand. If the word "until" is changed to "since" in these strings this would be perfectly clear to me. If I'm not mistaken, "until" is used for periods forward in time, while "since" is used for periods backward in time.
Sorry for being unclear in c#1. No, I think you got me wrong, It wouldn't be 'since'. Suppose white took these times for each move move1 : 5 move2 : 10 move3 : 6 Now, if it is white's 4th move then "white-last-move-seconds" = 5+10+6 = 21 Thats why I said "the seconds X has used until X's previous move" I understand this statement can be confusing, I'll think over it and try to improve it. and maybe add an explanatory comment. Ref: http://www.merriam-webster.com/dictionary/since http://www.merriam-webster.com/dictionary/until
Thank you, now I understand. It's the accumulated time until the previous move of the user. Indeed "until" can be used for that.
Anders, Would you like me to add a comment to the bug or its okay as is?
^I meant comment in the code**
Thanks for your time, I think a comment would be helpful. A translation comment like "accumulated time until previous move" or something like that would make it harder to misunderstand the string when translating. Regards, Anders
Wait a second, white-last-move-seconds and black-last-move-seconds are not preferences: they shouldn't be in the gschema at all. I remember discussing in review that these should be saved in the PGN instead and you implemented that change, but we missed that the preferences remained. So please just remove these.
Created attachment 297971 [details] [review] Removing unnecessary gschema variables
Pushed to master.