After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745134 - Weird behavior if Shift is released while highlighting
Weird behavior if Shift is released while highlighting
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
0.39.x
Other Linux
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-02-24 23:21 UTC by Egmont Koblinger
Modified: 2015-02-27 11:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix (3.77 KB, patch)
2015-02-25 18:22 UTC, Egmont Koblinger 		none Details | Review
Fix v2 (1.89 KB, patch)
2015-02-26 17:23 UTC, Egmont Koblinger 		committed Details | Review

Description Egmont Koblinger 2015-02-24 23:21:57 UTC 
Enable mouse mode (1002).  Start a selection by holding Shift down when clicking.  While dragging the mouse, at some point release Shift and continue dragging.

The selection is no longer extended.  Instead, motion mouse events (without click or release events) are sent to the apps.

I believe we should only check for Shift when clicking (this is what we do for Ctrl, and this is what xterm does too).  If we started a selection, we should remain in this mode even if the user releases Shift in the mean time.
Comment 1 Egmont Koblinger 2015-02-25 18:22:01 UTC 
Created attachment 297916 [details] [review]
Fix
Comment 2 Egmont Koblinger 2015-02-26 17:23:08 UTC 
Created attachment 298006 [details] [review]
Fix v2

Fix v2, it's simpler on top of bug 745131's fix v2.
Comment 3 Egmont Koblinger 2015-02-27 11:41:13 UTC 
Fixed