After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745104 - remote-display: remove spice detection
remote-display: remove spice detection
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2015-02-24 17:55 UTC by Marc-Andre Lureau
Modified: 2016-03-09 14:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
remote-display: remove spice detection (1.60 KB, patch)
2015-02-24 17:55 UTC, Marc-Andre Lureau
committed Details | Review

Description Marc-Andre Lureau 2015-02-24 17:55:13 UTC
Spice can be used with virgl for accelerated rendering.

The llvm-pipe check is enough for disabling animations when using the
QXL driver.
Comment 1 Marc-Andre Lureau 2015-02-24 17:55:17 UTC
Created attachment 297793 [details] [review]
remote-display: remove spice detection
Comment 2 Matthias Clasen 2015-02-25 00:54:08 UTC
Can you point me at documentation for using virgl with spice ? Does this work today if I run a vm in boxes ?
Comment 3 Marc-Andre Lureau 2015-02-25 01:20:02 UTC
(In reply to Matthias Clasen from comment #2)
> Can you point me at documentation for using virgl with spice ? Does this
> work today if I run a vm in boxes ?

Well, it's not easy today, you need a lot of development branches, at some specific revision. But yes, there is some proof-of-concept work to integrate virgl with spice locally.
Comment 4 Matthias Clasen 2015-02-25 01:23:10 UTC
then this bug should probably be targeted post-3.16 ?
Comment 5 Bastien Nocera 2015-02-25 09:32:11 UTC
Review of attachment 297793 [details] [review]:

To be committed for GNOME 3.18 (or whenever VirGL actually starts shipping to end-users).
Comment 6 Marc-Andre Lureau 2015-11-04 10:15:37 UTC
virgl is soon to be ready (merged in qemu & mesa and partially in kernel), I am looking at Spice integration again.

This patch is still valid.

An alternative for Spice/2d would be to check if the video driver is QXL instead. I don't know the best way to do that though.
Comment 7 Bastien Nocera 2015-11-04 10:18:33 UTC
Let me know when it's actually all upstream, and we'll commit it, hopefully for 3.20.
Comment 8 Marc-Andre Lureau 2015-11-04 12:55:52 UTC
(In reply to Bastien Nocera from comment #7)
> Let me know when it's actually all upstream, and we'll commit it, hopefully
> for 3.20.

I wish we would do that before, it's quite annoying for testing. It's the first thing you notice. If one can come up with a solution involving QXL driver check, could we have it before?
Comment 9 Bastien Nocera 2015-11-04 13:06:18 UTC
(In reply to Marc-Andre Lureau from comment #8)
> (In reply to Bastien Nocera from comment #7)
> > Let me know when it's actually all upstream, and we'll commit it, hopefully
> > for 3.20.
> 
> I wish we would do that before, it's quite annoying for testing.

Not sure I understand why you wouldn't be able to have a test gnome-settings-daemon for that, but hey.

> It's the
> first thing you notice. If one can come up with a solution involving QXL
> driver check, could we have it before?

That would be good enough, yes.
Comment 10 Marc-Andre Lureau 2015-11-13 12:02:07 UTC
actually, as I explained in comment #1, I don't think there is any reason to check for Spice. The llvm pipe check should be enough. please consider the patch as is. thanks
Comment 11 Marc-Andre Lureau 2016-03-08 16:35:01 UTC
(In reply to Bastien Nocera from comment #7)
> Let me know when it's actually all upstream, and we'll commit it, hopefully
> for 3.20.

ping

All the spice bits are now upstream, including libvirt/libvirt-glib bits. we are only missing a few pending patches for virt-manager & osinfo/boxes & releases.