GNOME Bugzilla – Bug 745098
Linting HTTPD module
Last modified: 2015-05-18 14:45:49 UTC
Created attachment 297786 [details] [review] Make HTTPD module lint compliant Here is a patch to make HTTPD module lint-compliant. I've splitted several classes and defines into separate files, but still got the error in autoload module in some of them, but I don't know why (I've followed the same steps I did with the sudo module...) Also, there is a warning about referencing files with puppet:/// without modules/. I guess this is beacuse cert files and so were removed from this module's files folder so, to avoid this warnings, you have to use the --no-puppet_url_without_modules-check when running the puppet-lint command. Maybe it would be interesstin to add this parameter to the pre-commit check I proposed in #744654 to avoid this check Thanks!
which class is not in autoload ?
These are the errors shown when runinng the check: apache_vhost.pp - ERROR: apache::vhost not in autoload module layout on line 3 httpd_redhat.pp - ERROR: httpd::redhat not in autoload module layout on line 3 httpd_vhost.pp - ERROR: httpd::vhost not in autoload module layout on line 3
your includes at the end of the file are wrong. they should be: include httpd::apache_vhost But in fact, you don't need to include them twice you already included them earlier.
I doesn't seem to be ok (yes, I have included some clases twice, that was wrong) but the error is in the apache_vhost.pp and httpd_* files themselves, not related with init.pp. There might be something wrong in that file, but can't see where...
right, the define should be: define httpd::apache::vhost rename httpd_rehat to redhat.pp rename httpd_vhost to vhost.pp
Went ahead and cleaned up the httpd class. Thanks Daniel for your original patch! https://infrastructure.gnome.org/browse/puppet/tree/modules/httpd/manifests