GNOME Bugzilla – Bug 745095
Notification list layout refinements
Last modified: 2015-02-26 16:49:03 UTC
Created attachment 297778 [details] modified screenshot Right now, the visual appearance of the notification list is a bit rough. I feel that it needs a bit of polish before release. The attachment shows an edited screenshot, to get an idea. Changes: * Add a border radius to list rows. * Reduce line spacing inside list rows. * Vertically center the two lines of text inside list rows. * Increase the width of the list. * More padding to the left of the icons, and even more to the left of event text. * Reduce the size of the time text. * Reduce the padding below the section headings.
Also, the calendar collumn that matches with the current day is not a perfect circle, but a ellipse. I don't know why.
Created attachment 297789 [details] [review] patch Here's an initial patch. It doesn't do everything listed, but seems like it takes of the worst of the rough edges.
Created attachment 297790 [details] [review] the right patch Sorry, I attached the wrong version - this is the right one.
Review of attachment 297790 [details] [review]: One comment, after that it's up to you and Jakub whether you are happy with the look. ::: _common.scss @@ +877,2 @@ .message-icon-bin { + padding: 8px 0px 8px 12px; Different values for left and right => needs :rtl handling
Created attachment 297864 [details] [review] patch With rtl handling.
Review of attachment 297864 [details] [review]: LGTM
I think that the border-radius property of the message boxes should be consistent with the panel border radius. Maybe 3px intead 6px, I think.
(In reply to Miguel Vaello Martínez from comment #7) > I think that the border-radius property of the message boxes should be > consistent with the panel border radius. Maybe 3px intead 6px, I think. I used 6px because that's the border radius for pop up banners, but I think you're right - 3px does look better here.
Created attachment 297908 [details] [review] patch This matches the message item border radius to that of the popover. I'd have liked to have removed some padding from below the list section headings, but I couldn't figure out how to do it - .message-list-section-title-box spacing seems to have no effect.
Created attachment 297909 [details] [review] patch Fix broken rtl in previous patch.
(In reply to Allan Day from comment #9) > I'd have liked to have removed some padding from below the list section > headings, but I couldn't figure out how to do it - > .message-list-section-title-box spacing seems to have no effect. .message-list-section-title-box is just the heading, i.e. its spacing only applies to section title and clear button. The spacing value in .message-list-section is what you're looking for.
Created attachment 297958 [details] before and after screenshot Screenshot of the patch in action, for the freeze break.
Freeze break was approved by the release team: https://mail.gnome.org/archives/release-team/2015-February/msg00094.html
Pushed: https://git.gnome.org/browse/gnome-shell-sass/commit/?id=fb6aeeaa63912a08e5cf721e6a822df4a463e812