After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745047 - openh264 dynamically link to gnustl instead of using gnstl.la
openh264 dynamically link to gnustl instead of using gnstl.la
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: cerbero
unspecified
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-02-23 20:21 UTC by Xavier Claessens
Modified: 2015-02-23 20:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
openh264: Fix static build (1.06 KB, patch)
2015-02-23 20:38 UTC, Xavier Claessens 		committed Details | Review

Description Xavier Claessens 2015-02-23 20:21:56 UTC 
openh264.recipe generates manually a .la file, with this:
        elif self.config.target_platform == Platform.ANDROID:
            dependency_libs += ['-lgnustl', '-lm']

The problem with this is that gnustl will be dynamically linked even when doing a static build of gstreamer because tools.mk won't convert it to its .a file.
Comment 1 Xavier Claessens 2015-02-23 20:24:17 UTC 
In comparaison, libtag.la has the full patch to libgnustl.la in its dependency_libs
Comment 2 Xavier Claessens 2015-02-23 20:38:46 UTC 
Created attachment 297714 [details] [review]
openh264: Fix static build

This avoids dynamically linking on gnustl, by setting the libgnustl.la
in libopenh264.la's dependency_libs.
Comment 3 Nicolas Dufresne (ndufresne) 2015-02-23 20:46:03 UTC 
Thanks !

commit 3695d0898170c62c55899eb9f5db083f205688d4
Author: Xavier Claessens <xavier.claessens@collabora.com>
Date:   Mon Feb 23 15:35:27 2015 -0500

    openh264: Fix static build
    
    This avoids dynamically linking on gnustl, by setting the libgnustl.la
    in libopenh264.la's dependency_libs.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=745047