After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745037 - Make sudo module lint-compliant
Make sudo module lint-compliant
Status: RESOLVED FIXED
Product: sysadmin
Classification: Infrastructure
Component: Apprentices
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Sysadmins
GNOME Sysadmins
Depends on:
Blocks:
 
 
Reported: 2015-02-23 17:47 UTC by Daniel Mustieles
Modified: 2015-03-27 14:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Sudo module linted (3.41 KB, patch)
2015-02-23 17:47 UTC, Daniel Mustieles
none Details | Review
Patch updated (3.77 KB, patch)
2015-02-24 11:41 UTC, Daniel Mustieles
none Details | Review

Description Daniel Mustieles 2015-02-23 17:47:11 UTC
Created attachment 297693 [details] [review]
Sudo module linted

Fixed all the errors and warnings, but there is still one I don't know how to fix:

ERROR: sudo::extra not in autoload module layout on line 58

Could you please help me with it?
Comment 1 matanya 2015-02-23 18:19:14 UTC
In a module layout, each class or define needs to be in a separate .pp file and called as needed. so you would want to take this define into a file called extra.pp and have the define there.
Comment 2 Daniel Mustieles 2015-02-24 11:41:39 UTC
Created attachment 297756 [details] [review]
Patch updated

Right, here is the patch updated. Hope now it's ok.

Thanks!
Comment 3 Andrea Veri 2015-03-27 13:36:55 UTC
Patch has been merged, thanks Daniel!

https://infrastructure.gnome.org/browse/puppet/commit/?id=fb55344bdc7134f120d5209fbbbcfa0f83aae811
Comment 4 Andrea Veri 2015-03-27 14:35:36 UTC
As a side note, make sure to not include items that are not classes as you did with sudo::extra, these are defined types which are actually explicitly called from the node files themselves.