GNOME Bugzilla – Bug 745022
Drop deprecated API
Last modified: 2015-02-23 15:35:55 UTC
Ensure that the build does not suck too badly. While technically the changes inside libgdict amount to an ABI break, there are mitigating factors: • nothing is subclassing these types, as far as we know • GtkVBox has the same size of GtkBox • GtkVBox has no API, except the type function and a constructor
Created attachment 297655 [details] [review] build: Do not use INCLUDES It's deprecated, and we can replace it with a target specific CPPFLAGS stanza.
Created attachment 297656 [details] [review] build: Do not use INCLUDES It's deprecated. We should be using AM_CPPFLAGS, in this case, since we share the same pre-processor flags with the introspection scanner.
Created attachment 297657 [details] [review] build: Modernize autotools usage While not really bleeding edge, at least we have something adequate for this century.
Created attachment 297658 [details] [review] gdict: Fix introspection annotations This brings down the number of g-ir-scanner warnings to zero.
Created attachment 297659 [details] [review] gdict: Remove GTK_STOCK_* usage We're still allowing it from users of the API, but internally we don't use images from stock ids.
Created attachment 297660 [details] [review] app: Remove use of deprecated stock items We want proper labels, and we want to drop deprecation warnings.
Created attachment 297661 [details] [review] window: Do not use deprecate composite-child API It's useless anyway.
Created attachment 297662 [details] [review] gdict: Silence a compiler warning NULL is not FALSE.
Created attachment 297663 [details] [review] gdict: Drop deprecated API from DatabaseChooser Remove all the deprecation warnings. *** WARNING *** This is really an API change, since GtkBox is not a GtkVBox; on the other hand: • nothing is really subclassing this type • GtkVBox does not have any API except a constructor
Created attachment 297664 [details] [review] gdict: Drop deprecated API from SourceChooser Remove all the deprecation warnings. *** WARNING *** This is really an API change, since GtkBox is not a GtkVBox; on the other hand: • nothing is really subclassing this type • GtkVBox does not have any API except a constructor
Created attachment 297666 [details] [review] gdict: Drop deprecated API from Speller Remove all the deprecation warnings. *** WARNING *** This is really an API change, since GtkBox is not a GtkVBox; on the other hand: • nothing is really subclassing this type • GtkVBox does not have any API except a constructor
Created attachment 297667 [details] [review] gdict: Drop deprecated API from StrategyChooser Remove all the deprecation warnings. *** WARNING *** This is really an API change, since GtkBox is not a GtkVBox; on the other hand: • nothing is really subclassing this type • GtkVBox does not have any API except a constructor
Created attachment 297668 [details] [review] gdict: Drop deprecated API from DefBox Remove all the deprecation warnings. *** WARNING *** This is really an API change, since GtkBox is not a GtkVBox; on the other hand: • nothing is really subclassing this type • GtkVBox does not have any API except a constructor
Created attachment 297669 [details] [review] app: Drop all deprecated API
Created attachment 297670 [details] [review] Bump the libgdict soname We changed parts of the ABI.
Created attachment 297671 [details] [review] docs: Fix up the documentation build
Created attachment 297676 [details] [review] Bump up the GTK+ requirement
Attachment 297655 [details] pushed as 04094b0 - build: Do not use INCLUDES Attachment 297656 [details] pushed as 04094b0 - build: Do not use INCLUDES Attachment 297657 [details] pushed as e5eb618 - build: Modernize autotools usage Attachment 297658 [details] pushed as d864ca5 - gdict: Fix introspection annotations Attachment 297659 [details] pushed as 66e8e50 - gdict: Remove GTK_STOCK_* usage Attachment 297660 [details] pushed as 496b111 - app: Remove use of deprecated stock items Attachment 297661 [details] pushed as f353608 - window: Do not use deprecate composite-child API Attachment 297662 [details] pushed as 466408b - gdict: Silence a compiler warning Attachment 297663 [details] pushed as 2ab2182 - gdict: Drop deprecated API from DatabaseChooser Attachment 297664 [details] pushed as d078eaf - gdict: Drop deprecated API from SourceChooser Attachment 297666 [details] pushed as f9c484d - gdict: Drop deprecated API from Speller Attachment 297667 [details] pushed as 2cd2500 - gdict: Drop deprecated API from StrategyChooser Attachment 297668 [details] pushed as 533b6d6 - gdict: Drop deprecated API from DefBox Attachment 297669 [details] pushed as c60d8c8 - app: Drop all deprecated API Attachment 297670 [details] pushed as fa69aa0 - Bump the libgdict soname Attachment 297671 [details] pushed as 69eae8d - docs: Fix up the documentation build Attachment 297676 [details] pushed as 0cbca4c - Bump up the GTK+ requirement