After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744975 - Don't allow opening scores dialog if no scores exist
Don't allow opening scores dialog if no scores exist
Status: RESOLVED FIXED
Product: gnome-2048
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-2048 maintainer(s)
gnome-2048 maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-02-22 18:28 UTC by Michael Catanzaro
Modified: 2015-02-22 23:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Don't allow opening scores dialog if no scores exist (1.40 KB, patch)
2015-02-22 18:28 UTC, Michael Catanzaro
none Details | Review
Don't allow opening scores dialog if no scores exist (1.39 KB, patch)
2015-02-22 23:05 UTC, Michael Catanzaro
none Details | Review

Description Michael Catanzaro 2015-02-22 18:28:31 UTC
The scores dialog looks pretty bad when no scores exist. I've added a warning that will print if it's opened when no scores exist; games should make sure that doesn't happen.
Comment 1 Michael Catanzaro 2015-02-22 18:28:34 UTC
Created attachment 297587 [details] [review]
Don't allow opening scores dialog if no scores exist

The scores dialog seems to be pretty broken right now, but pretty sure
the code in GNOME 2048 is correct.
Comment 2 Michael Catanzaro 2015-02-22 23:05:11 UTC
Created attachment 297608 [details] [review]
Don't allow opening scores dialog if no scores exist

The scores dialog seems to be pretty broken right now, but pretty sure
the code in GNOME 2048 is correct.
Comment 3 Michael Catanzaro 2015-02-22 23:46:11 UTC
Attachment 297608 [details] pushed as 34134f1 - Don't allow opening scores dialog if no scores exist