GNOME Bugzilla – Bug 744974
Linting gnome_network
Last modified: 2015-02-24 18:01:40 UTC
Created attachment 297586 [details] [review] linting gnome_network This reduces the amount of warnings reported from [tobiasmue@bastion puppet.git]$ puppet-lint modules//gnome_network/manifests/init.pp WARNING: unquoted file mode on line 6 WARNING: unquoted file mode on line 16 WARNING: double quoted string containing no variables on line 4 WARNING: double quoted string containing no variables on line 5 WARNING: double quoted string containing no variables on line 10 WARNING: double quoted string containing no variables on line 14 WARNING: double quoted string containing no variables on line 15 WARNING: double quoted string containing no variables on line 20 WARNING: indentation of => is not properly aligned on line 5 WARNING: indentation of => is not properly aligned on line 6 WARNING: indentation of => is not properly aligned on line 7 WARNING: indentation of => is not properly aligned on line 8 WARNING: indentation of => is not properly aligned on line 9 WARNING: indentation of => is not properly aligned on line 15 WARNING: indentation of => is not properly aligned on line 16 WARNING: indentation of => is not properly aligned on line 17 WARNING: indentation of => is not properly aligned on line 18 WARNING: indentation of => is not properly aligned on line 19 ERROR: tab character found on line 3 ERROR: tab character found on line 3 ERROR: tab character found on line 4 ERROR: tab character found on line 5 ERROR: tab character found on line 6 ERROR: tab character found on line 7 ERROR: tab character found on line 8 ERROR: tab character found on line 9 ERROR: tab character found on line 10 ERROR: tab character found on line 11 ERROR: tab character found on line 13 ERROR: tab character found on line 13 ERROR: tab character found on line 14 ERROR: tab character found on line 15 ERROR: tab character found on line 16 ERROR: tab character found on line 17 ERROR: tab character found on line 18 ERROR: tab character found on line 19 ERROR: tab character found on line 20 ERROR: tab character found on line 21 WARNING: class not documented on line 1 WARNING: mode should be represented as a 4 digit octal value or symbolic mode on line 6 WARNING: mode should be represented as a 4 digit octal value or symbolic mode on line 16 ERROR: two-space soft tabs not used on line 3 ERROR: two-space soft tabs not used on line 5 ERROR: two-space soft tabs not used on line 6 ERROR: two-space soft tabs not used on line 7 ERROR: two-space soft tabs not used on line 8 ERROR: two-space soft tabs not used on line 9 ERROR: two-space soft tabs not used on line 10 ERROR: two-space soft tabs not used on line 11 ERROR: two-space soft tabs not used on line 13 ERROR: two-space soft tabs not used on line 15 ERROR: two-space soft tabs not used on line 16 ERROR: two-space soft tabs not used on line 17 ERROR: two-space soft tabs not used on line 18 ERROR: two-space soft tabs not used on line 19 ERROR: two-space soft tabs not used on line 20 ERROR: two-space soft tabs not used on line 21 ERROR: trailing whitespace found on line 3 ERROR: trailing whitespace found on line 13 WARNING: ensure found on line but it's not the first attribute on line 9 WARNING: ensure found on line but it's not the first attribute on line 19 [tobiasmue@bastion puppet.git]$ to [tobiasmue@bastion puppet.git]$ puppet-lint modules//gnome_network/manifests/init.pp WARNING: indentation of => is not properly aligned on line 5 WARNING: indentation of => is not properly aligned on line 6 WARNING: indentation of => is not properly aligned on line 7 WARNING: indentation of => is not properly aligned on line 8 WARNING: indentation of => is not properly aligned on line 9 WARNING: indentation of => is not properly aligned on line 15 WARNING: indentation of => is not properly aligned on line 16 WARNING: indentation of => is not properly aligned on line 17 WARNING: indentation of => is not properly aligned on line 18 WARNING: indentation of => is not properly aligned on line 19 WARNING: class not documented on line 1 WARNING: ensure found on line but it's not the first attribute on line 9 WARNING: ensure found on line but it's not the first attribute on line 19
Comment on attachment 297586 [details] [review] linting gnome_network Committed. Thanks!