After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744972 - Rename the desktop and appdata files
Rename the desktop and appdata files
Status: RESOLVED FIXED
Product: gnome-2048
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-2048 maintainer(s)
gnome-2048 maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-02-22 16:55 UTC by Michael Catanzaro
Modified: 2015-02-23 00:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Rename the desktop and appdata files (2.83 KB, patch)
2015-02-22 16:55 UTC, Michael Catanzaro 		none Details | Review
Rename the desktop and appdata files (2.91 KB, patch)
2015-02-22 17:00 UTC, Michael Catanzaro 		reviewed Details | Review
Fix application name (771 bytes, patch)
2015-02-23 00:25 UTC, Michael Catanzaro 		none Details | Review

Description Michael Catanzaro 2015-02-22 16:55:16 UTC 
Let's use the name org.gnome.2048, so that we can support D-Bus activation if we choose to do so later.
Comment 1 Michael Catanzaro 2015-02-22 16:55:18 UTC 
Created attachment 297583 [details] [review]
Rename the desktop and appdata files

We need to use reverse-DNS notation for D-Bus activation. This commit
doesn't add support for D-Bus activation, it just future-proofs the name
of the desktop file so we don't have to later rename it and add it to the
hardcoded list of renamed desktop files in gnome-shell.
Comment 2 Michael Catanzaro 2015-02-22 17:00:37 UTC 
Created attachment 297584 [details] [review]
Rename the desktop and appdata files

Soooo bus names cannot start with a number. :( I guess org.gnome.gnome-2048 will have to do instead, though it reads rather funny.
Comment 3 Juan R. Garcia Blanco 2015-02-22 21:07:50 UTC 
Review of attachment 297584 [details] [review]:

::: src/application.vala
@@ +406,3 @@
     }
 
+    Environment.set_application_name ("org.gnome.2048");

Shouldn't this be org.gnome.gnome-2048?
Comment 4 Michael Catanzaro 2015-02-22 23:46:06 UTC 
Attachment 297584 [details] pushed as 73f6d64 - Rename the desktop and appdata files
Comment 5 Michael Catanzaro 2015-02-23 00:24:32 UTC 
(In reply to Juan R. Garcia Blanco from comment #3) 
> Shouldn't this be org.gnome.gnome-2048?

Yup. Oops.
Comment 6 Michael Catanzaro 2015-02-23 00:25:13 UTC 
The following fix has been pushed:
291d89d Fix application name
Comment 7 Michael Catanzaro 2015-02-23 00:25:16 UTC 
Created attachment 297611 [details] [review]
Fix application name