GNOME Bugzilla – Bug 744918
Update Help Manual for Mike Alexanders mods to Advanced Portfolio Rpt
Last modified: 2018-06-29 23:38:44 UTC
This is for me (Chris Good) to do. Document mods where it is sometimes not necessary to add a dummy stock transaction to non reinvested dividend transactions in order for them to be included in Income.
Created attachment 298199 [details] [review] Patch to Help_ch_Reports.xml Here is patch to document Mike's mod which will be included in GnuCash 2.6.6. Can some-one please incorporate.
This patch looks ok to me.
The following fix has been pushed: c615c87 Document Mike Alexander mod to Advanced Portfolio Report Thank you for your contribution.
Created attachment 299843 [details] [review] Document Mike Alexander mod to Advanced Portfolio Report Mike has modified advanced-portfolio.scm so that in some circumstances it is not necessary to add a dummy stock split to an income transaction in order for the income to be automatically included. This was done as part of multiple bugs.
Comment on attachment 298199 [details] [review] Patch to Help_ch_Reports.xml Hmm, I was using "git bz push" to push your fix to our repository. It didn't handle the bug report as I expected. So with this I'll mark your patch as committed.
Review of attachment 299843 [details] [review]: This is just a copy of your patch (with a few git white-space warnings fixed) that got attached again by my use of "git bz push". I've marked it as committed as well now.
Lastly a small bug management nit: if you create a patch that should be included in the next stable release, please set the version to git-maint. I almost committed your patch to master, in which case it would only have appeared starting from gnucash 2.8.0 (still a few years away). Thanks again however for your contributions!
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=744918. Please update any external references or bookmarks.