After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744903 - triggers: fix LiteralMatch vs REMatch problems
triggers: fix LiteralMatch vs REMatch problems
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2015-02-21 18:24 UTC by Allison Karlitskaya (desrt)
Modified: 2015-02-22 23:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
triggers: fix LiteralMatch vs REMatch problems (1.38 KB, patch)
2015-02-21 18:24 UTC, Allison Karlitskaya (desrt)
committed Details | Review

Description Allison Karlitskaya (desrt) 2015-02-21 18:24:31 UTC
See patch.
Comment 1 Allison Karlitskaya (desrt) 2015-02-21 18:24:35 UTC
Created attachment 297518 [details] [review]
triggers: fix LiteralMatch vs REMatch problems

ceaa03131d0ccdf80797228dd901a0af82bd12f8 tried to "fix" the failing
regular expression matches for several triggers, but made the mistake of
adding '^' to LiteralMatch lines.  Change those to REMatch lines so that
they work properly.
Comment 2 Colin Walters 2015-02-22 19:01:48 UTC
Review of attachment 297518 [details] [review]:

Ok, though I would personally just go back to LiteralMatch without a leading /.
Comment 3 Allison Karlitskaya (desrt) 2015-02-22 23:17:48 UTC
Attachment 297518 [details] pushed as abe8469 - triggers: fix LiteralMatch vs REMatch problems