GNOME Bugzilla – Bug 744899
Devhelp search provider for global search
Last modified: 2015-03-29 22:31:52 UTC
This is a set of patches for adding a devhelp search-provider to global search. I'm tired of writing a method name to look its documentation and sometimes I don't even know the signature correct so.
Created attachment 297504 [details] [review] helper API to GbDevhelpDocument
Created attachment 297505 [details] [review] 0002-editor-workspace-add-gb_editor_workspace_focus_docum.patch
Created attachment 297506 [details] [review] 0003-devhelp-add-search-provider-implementation.patch
Created attachment 297507 [details] [review] 0004-workbench-use-devhelp-search-provider.patch
Now, the implementation throw still some warning about G_DECLARE_FINAL_TYPE and g_auto_ptr at build time. I haven't not fixed it because I'm not sure if the provider belongs to GbSearchProvider or IdeSearchProvider. As a matter of design, I think this belong into GbSearchProvider more than in libide library. Anyhow, the implementation works using GbSearchProvider, I'll migrate it if needed or fix the warning if it can stays using GbSearchProvider.
So to sum up our discussion on IRC. 1) Use IdeSearchProvider as a base class 2) Continue using G_DECLARE_FINAL_TYPE(). 3) I'll get IdeSearchEngine hooked into the workbench (and GbSearchProvider will disappear) 4) I'll add IdeSearchProvider::activate(IdeSearchResult*) signal. 5) Make your result use that (if necessary) Thanks again for doing this, very necessary!
Created attachment 298128 [details] [review] 0001-search-add-devhelp-provider.patch
Created attachment 298129 [details] [review] 0002-libide-use-devhelp-search-provider.patch
(In reply to Christian Hergert from comment #6) > So to sum up our discussion on IRC. > > 1) Use IdeSearchProvider as a base class > 2) Continue using G_DECLARE_FINAL_TYPE(). Done and done. > 3) I'll get IdeSearchEngine hooked into the workbench (and GbSearchProvider > will disappear) > 4) I'll add IdeSearchProvider::activate(IdeSearchResult*) signal. > 5) Make your result use that (if necessary) Now, all that's needed is the hooking of this on the UI. This will have to wait until libide branch I merged into master I guess.
LGTM, thanks!
Actually, I'm going to leave this open until we have the UI in place.
That's been done!