After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744887 - Warning when opening a machine's properties
Warning when opening a machine's properties
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: 3.22
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-02-21 12:00 UTC by Adrien Plazas
Modified: 2016-03-31 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
app-window: Check UIState before setting selection_mode prop (1.29 KB, patch)
2015-02-21 12:09 UTC, Adrien Plazas 		needs-work Details | Review
app-window: Reset selection mode if appropriate (1.28 KB, patch)
2015-02-21 13:20 UTC, Adrien Plazas 		committed Details | Review

Description Adrien Plazas 2015-02-21 12:00:21 UTC 
Boxes produces this warning when opening a machine's properties dialog from anywhere but the collection view.

(gnome-boxes:31199): Boxes-CRITICAL **: boxes_app_window_set_selection_mode: assertion '_tmp1_ == BOXES_UI_STATE_COLLECTION' failed
Comment 1 Adrien Plazas 2015-02-21 12:09:29 UTC 
Created attachment 297487 [details] [review]
app-window: Check UIState before setting selection_mode prop

This checks if the UIState is COLLECTION before setting the
selection_mode property. It fixes a runtime warning.
Comment 2 Lasse Schuirmann 2015-02-21 13:00:38 UTC 
Review of attachment 297487 [details] [review]:

Proposal for shortlog that doesnt violate the 50 char rule:

app-window: Reset selection mode if appropriate

looks good otherwise
Comment 3 Adrien Plazas 2015-02-21 13:20:41 UTC 
Created attachment 297494 [details] [review]
app-window: Reset selection mode if appropriate

This checks if the UIState is COLLECTION before setting the
selection_mode property. It fixes a runtime warning.
Comment 4 Lasse Schuirmann 2015-02-21 13:27:15 UTC 
Review of attachment 297494 [details] [review]:

Ack, thanks for the patch.
Comment 5 Lasse Schuirmann 2015-02-21 19:30:39 UTC 
Review of attachment 297494 [details] [review]:

committed
Comment 6 Zeeshan Ali 2015-02-21 22:19:04 UTC 
Review of attachment 297494 [details] [review]:

Thanks for the fix and thanks Lasse for review. This was pretty trivial and important so its good you pushed as soon as you got an ack but for future ref, if its not a trivial patch like this one, please give me some time to also review before pushing.
Comment 7 Lasse Schuirmann 2015-02-21 22:25:08 UTC 
I pushed, sorry. I'll leave you more time next time.
Comment 8 Zeeshan Ali 2015-02-21 22:30:24 UTC 
(In reply to Lasse Schuirmann from comment #7)
> I pushed, sorry. I'll leave you more time next time.

No! I thought made it clear that it was a good thing it was pushed but I guess I failed. :(