After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744853 - Add support for multicast_snooping option for bridges
Add support for multicast_snooping option for bridges
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: nm-connection-editor
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-02-20 13:17 UTC by Jiri Klimes
Modified: 2015-03-02 08:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Jiri Klimes 2015-02-20 13:17:38 UTC 
There are requests for NetworkManager to support multicast_snooping option, see e.g. [1] or [2].
The documentation for the option is here [3].

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1046074
[2] http://blog.shlrm.org/blog/2013/04/18/multicast-snooping-is-bad/
[3] http://www.linuxfoundation.org/collaborate/workgroups/networking/bridge#Snooping
Comment 1 Jiri Klimes 2015-02-20 13:26:56 UTC 
I have written the code to handle the option.
See NetworkManager repository branch jk/bridge-mcast-snoop-bgo744853.
Comment 2 Thomas Haller 2015-02-20 16:24:22 UTC 
LGTM
Comment 3 Dan Winship 2015-02-25 16:07:09 UTC 
LGTM too
Comment 4 Jiri Klimes 2015-02-26 09:10:27 UTC 
Merged to master:
af50945 merge: add 'multicast_snooping' bridge option to NetworkManager (bgo #744853)
591908c nmcli: add support for bridge multicast-snooping property
dead766 keyfile: update testcase for multicast-snooping property
b9c79de ifcfg-rh: read/write multicast-snooping property
1252386 device: add multicast-snooping option support
11efde3 libnm-core: add multicast-snooping property to bridge setting
Comment 5 Jiri Klimes 2015-02-27 13:25:30 UTC 
Re-opening for nm-connection-editor support of IGMP snooping.
See network-manager-applet's jk/editor-bridge-igmp-snoop-bgo744853 branch.
Comment 6 Dan Williams 2015-02-28 14:25:49 UTC 
jk/editor-bridge-igmp-snoop-bgo744853 looks good to me and seems to work OK from a quick test.
Comment 7 Jiri Klimes 2015-03-02 08:46:39 UTC 
(In reply to Dan Williams from comment #6)
> jk/editor-bridge-igmp-snoop-bgo744853 looks good to me and seems to work OK
> from a quick test.

Pushed to network-manager-applet's master:
5548897 editor: allow setting multicast_snooping option for bridges (bgo #744853)
Comment 8 Jiri Klimes 2015-03-02 08:47:59 UTC 
Also added the option to nmtui:
cdc8bd1 tui: add "Enable IGMP snooping" to bridge editor (bgo #744853)