After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744827 - Empty stars in 'Search' view
Empty stars in 'Search' view
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other All
: Normal enhancement
: 3.18
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2015-02-19 23:22 UTC by Maia
Modified: 2015-09-07 11:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fixing favorite star rendering in searches (7.06 KB, patch)
2015-09-05 14:08 UTC, Hapoofesgeli 		none Details | Review

Description Maia 2015-02-19 23:22:33 UTC 
Currently, favorite tracks show up with a star in Search view, and the star can be toggled on and off, but the empty-star outline does not appear for non-favorite tracks. Non-favorite local tracks should have an empty star in search view (as opposed to tracks from external sources, which will have no star icon at all).
Comment 1 Hapoofesgeli 2015-09-05 14:08:57 UTC 
Created attachment 310699 [details] [review]
Fixing favorite star rendering in searches

Fixing the problem as mentioned, which also prevents crashes which happened when we clicked on the hidden stars of objects that can't have a favorite tag.
---
Tough the data types in the code have no names or comments and I'm not sure whether I've changed the right ones or not, please check that one.
Comment 2 Vadim Rutkovsky 2015-09-07 11:47:18 UTC 
Looks good to me, no regressions spotted. Pushed https://git.gnome.org/browse/gnome-music/commit/?id=a1477b8 to master, thanks!