After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744821 - Select Playlist button doesn't de/activate when navigating with arrow keys
Select Playlist button doesn't de/activate when navigating with arrow keys
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other other
: Normal minor
: 3.18
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2015-02-19 21:25 UTC by Maia
Modified: 2016-03-14 14:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Toggle Select Button on selection change (1.72 KB, patch)
2016-03-09 20:16 UTC, Gaurav Narula 		committed Details | Review

Description Maia 2015-02-19 21:25:18 UTC 
In the Playlist Dialog ('select playlist'/'add new playlist' menu), if you click on 'New Playlist', the 'select' button deactivates, and you get a text field in which to name your new playlist. If you navigate to the 'New Playlist' row via the arrow keys, the 'select' button does NOT deactivate--you can click 'select' from here, which crashes the program (with error: "'NoneType' object has no attribute 'get_id'").

Additionally, if you navigate up from 'New Playlist' to a valid playlist with the arrow keys, 'select' does not activate until you've selected a valid playlist via click.
Comment 1 Allan Day 2016-01-06 13:11:33 UTC 
Bulk removing the 3.18 target.
Comment 2 Gaurav Narula 2016-03-09 20:16:27 UTC 
Created attachment 323549 [details] [review]
Toggle Select Button on selection change

The current implementation connects to the 'row-activated' signal which is not emitted for the New Playlist . This patch adds a handler for the 'changed' signal of TreeSelection and updates the Select button accordingly.
Comment 3 Felipe Borges 2016-03-14 14:22:21 UTC 
Review of attachment 323549 [details] [review]:

Sure. thanks for your patch.