After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744815 - Some updates to built-in notifications and exposed notification capabilities
Some updates to built-in notifications and exposed notification capabilities
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2015-02-19 19:22 UTC by Florian Müllner
Modified: 2015-02-20 01:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
notificationDaemon: Remove support for legacy status icons (9.76 KB, patch)
2015-02-19 19:22 UTC, Florian Müllner
committed Details | Review
autorunManager: Remove resident notification (8.76 KB, patch)
2015-02-19 19:22 UTC, Florian Müllner
committed Details | Review
autorunManager: Use a regular urgent notification (5.85 KB, patch)
2015-02-19 19:22 UTC, Florian Müllner
committed Details | Review
autorunManager: Remove eject support (3.18 KB, patch)
2015-02-19 19:22 UTC, Florian Müllner
committed Details | Review
messageTray: Remove support for images in notifications (6.03 KB, patch)
2015-02-19 19:22 UTC, Florian Müllner
committed Details | Review
messageTray: Remove support for Music notifications (7.73 KB, patch)
2015-02-19 19:22 UTC, Florian Müllner
committed Details | Review
notificationDaemon: Remove support for action-icons (2.76 KB, patch)
2015-02-19 19:22 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2015-02-19 19:22:01 UTC
By now it's hardly a secret anymore that some major notification changes are about to happen - let's start with some minor bits that are mostly independent from the rest (and don't depend on the theme rework that is happening in parallel) ...
Comment 1 Florian Müllner 2015-02-19 19:22:11 UTC
Created attachment 297299 [details] [review]
notificationDaemon: Remove support for legacy status icons

Tray icons make for a terrible UI on their own, but trying to
shoehorn them into the notification system has only made them
worse. At least for the time being this removal is temporary
and support for tray icons will be back, but no longer as part
of the notification system.
Comment 2 Florian Müllner 2015-02-19 19:22:16 UTC
Created attachment 297300 [details] [review]
autorunManager: Remove resident notification

The new notification system will no longer give access to actions
from the notifications list, so a notification that is never
displayed as banner does not make sense here.
Comment 3 Florian Müllner 2015-02-19 19:22:22 UTC
Created attachment 297301 [details] [review]
autorunManager: Use a regular urgent notification

According to the design, hotplug notifications should no longer offer
an eject action and use regular notification buttons (but using icon
and text), the default action when clicking the notification itself
is to launch the file browser.
Also as the corresponding resident notification is gone, it no
longer makes sense to make the notification transient.
Comment 4 Florian Müllner 2015-02-19 19:22:27 UTC
Created attachment 297302 [details] [review]
autorunManager: Remove eject support

It's no longer exposed anywhere (by design), so kill off the now
unused bits.
Comment 5 Florian Müllner 2015-02-19 19:22:32 UTC
Created attachment 297304 [details] [review]
messageTray: Remove support for images in notifications

The design says they are no longer a thing.
Comment 6 Florian Müllner 2015-02-19 19:22:38 UTC
Created attachment 297305 [details] [review]
messageTray: Remove support for Music notifications

Music is no longer a special type of notification according
to the design. If we want to resurrect the functionality, we
can reimplement it with a dedicated API like MPRIS rather
than piggy-bagging on the notification system.
Comment 7 Florian Müllner 2015-02-19 19:22:44 UTC
Created attachment 297306 [details] [review]
notificationDaemon: Remove support for action-icons

This capability was only really useful for media players, and with
music notifications no longer being special, we can simplify a bit
by removing support for it.
Comment 8 Jasper St. Pierre (not reading bugmail) 2015-02-19 19:34:02 UTC
Review of attachment 297300 [details] [review]:

OK.
Comment 9 Jasper St. Pierre (not reading bugmail) 2015-02-19 19:34:24 UTC
Review of attachment 297302 [details] [review]:

Sure.
Comment 10 Jasper St. Pierre (not reading bugmail) 2015-02-19 19:34:50 UTC
Review of attachment 297301 [details] [review]:

Got it.
Comment 11 Jasper St. Pierre (not reading bugmail) 2015-02-19 19:35:18 UTC
Review of attachment 297305 [details] [review]:

Go for it.
Comment 12 Jasper St. Pierre (not reading bugmail) 2015-02-19 19:35:36 UTC
Review of attachment 297304 [details] [review]:

RIP.
Comment 13 Jasper St. Pierre (not reading bugmail) 2015-02-19 19:36:16 UTC
Review of attachment 297306 [details] [review]:

Gut it.
Comment 14 Jasper St. Pierre (not reading bugmail) 2015-02-19 19:37:12 UTC
Review of attachment 297299 [details] [review]:

OK.
Comment 15 Florian Müllner 2015-02-20 00:59:31 UTC
Attachment 297299 [details] pushed as 5a8923e - notificationDaemon: Remove support for legacy status icons
Attachment 297300 [details] pushed as a4fb55b - autorunManager: Remove resident notification
Attachment 297301 [details] pushed as aa2ae29 - autorunManager: Use a regular urgent notification
Attachment 297302 [details] pushed as 240cdc6 - autorunManager: Remove eject support
Attachment 297304 [details] pushed as f08e2b7 - messageTray: Remove support for images in notifications
Attachment 297305 [details] pushed as ea9e5bc - messageTray: Remove support for Music notifications
Attachment 297306 [details] pushed as f430114 - notificationDaemon: Remove support for action-icons