After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744789 - Show fav songs status on Artists view
Show fav songs status on Artists view
Status: RESOLVED OBSOLETE
Product: gnome-music
Classification: Applications
Component: general
3.15.x
Other Linux
: Low enhancement
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2015-02-19 14:44 UTC by Vadim Rutkovsky
Modified: 2018-01-10 14:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
A patch to show favorite songs on artists view (5.14 KB, patch)
2016-02-26 15:46 UTC, Prashant Tyagi 		none Details | Review

Description Vadim Rutkovsky 2015-02-19 14:44:18 UTC 
We should display stars nearby favourite tracks on Artist view. In order to decrease load we should remove ability to fav the song temporarily - see Search view implementation
Comment 1 Allan Day 2016-01-06 13:11:35 UTC 
Bulk removing the 3.18 target.
Comment 2 Prashant Tyagi 2016-02-26 15:46:46 UTC 
Created attachment 322474 [details] [review]
A patch to show favorite songs on artists view

This is basically a patch to show favorite songs on artist view.
Comment 3 Felipe Borges 2016-02-29 12:22:03 UTC 
Review of attachment 322474 [details] [review]:

Thanks for your patch.

Before any code review, I would like to hear from designers whether:
- this is something we want to show there;
- the stars should be on the right or the left side of the songs title;
- the stars should be horizontally aligned;
Comment 4 Marinus Schraal 2017-04-25 13:14:07 UTC 
This is trivial to do with the new disclistboxwidget, I just wonder if it isn't too much clutter.

1 thing that would need fixing is that an album with a single song would have it's star aligned to the full length of the 2 columns.
Comment 5 GNOME Infrastructure Team 2018-01-10 14:43:21 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-music/issues/32.