After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744781 - validate: Determine development mode using git hash value
validate: Determine development mode using git hash value
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-devtools
git master
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-02-19 12:29 UTC by Young Han Lee
Modified: 2015-02-19 13:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Determine development mode using git hash value (1.92 KB, patch)
2015-02-19 12:31 UTC, Young Han Lee
none Details | Review

Description Young Han Lee 2015-02-19 12:29:18 UTC
Currently _in_devel() in gst-validate-launcher determines development mode by whether the launcher script is in git repo or not. This could be wrong when the script is installed to subdirectory of other project's git repo, such as jhbuild.

It is normal to install output files to a subdirectory of your jhbuild which is also git repo. I installed output files to /my-jhbuild/install/ and found out that gst-validate-launcher misbehave because it determines it is in developement mode.
Comment 1 Young Han Lee 2015-02-19 12:31:46 UTC
Created attachment 297262 [details] [review]
Determine development mode using git hash value

This patch makes _in_devel() get the first commit hash of current git repo and compares it with gst-devtools' the first commit hash.
Comment 2 Thibault Saunier 2015-02-19 13:01:44 UTC
commit 2d6c667c9ad3e1c443aa72d28e31807cdb249e58
Author: Young Han Lee <joybro201@gmail.com>
Date:   Thu Feb 19 20:53:16 2015 +0900

    validate: Determine development mode using git hash value
    
    Development mode has been determined by whether the launcher is in git
    repo
    or not. This could be wrong when the launcher is installed to
    subdirectory of other project's git repo, such as jhbuild. It is normal
    to install compiled output to subdirectory of your jhbuild.
    
    Changed logic gets the first commit hash of current git repo and
    compares it with gst-devtools' the first commit hash.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=744781