After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744756 - Can't find out if gapplication is marked as busy
Can't find out if gapplication is marked as busy
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gapplication
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2015-02-18 19:53 UTC by Lars Karlitski
Modified: 2015-02-19 07:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gapplication: add "is-busy" (5.75 KB, patch)
2015-02-18 19:53 UTC, Lars Karlitski 		needs-work Details | Review
gapplication: add "is-busy" (4.24 KB, patch)
2015-02-18 23:42 UTC, Lars Karlitski 		committed Details | Review
gapplication: test setting and binding busy state (2.76 KB, patch)
2015-02-18 23:42 UTC, Lars Karlitski 		committed Details | Review

Description Lars Karlitski 2015-02-18 19:53:14 UTC 
It's impossible to find out from inside an application wether it is currently
marked as busy.

The attached patch adds an "is-busy" property for this purpose.
Comment 1 Lars Karlitski 2015-02-18 19:53:18 UTC 
Created attachment 297152 [details] [review]
gapplication: add "is-busy"

A property that lets the app query its busy state.

Also add a test for the busy state and binding properties to it.
Comment 2 Allison Karlitskaya (desrt) 2015-02-18 19:58:14 UTC 
Review of attachment 297152 [details] [review]:

As usual, missing gio-sections.txt additions :)

Please split the test into a separate commit.

Please also expand the tests a bit: test multiple busy markers and mixing calls to _mark_busy() with property-based busy notification.

::: gio/gapplication.c
@@ +1349,3 @@
                          G_PARAM_DEPRECATED | G_PARAM_WRITABLE | G_PARAM_STATIC_STRINGS));
 
+  g_object_class_install_property (object_class, PROP_IS_BUSY,

Missing doc string here.
Comment 3 Lars Karlitski 2015-02-18 23:42:39 UTC 
Created attachment 297232 [details] [review]
gapplication: add "is-busy"
Comment 4 Lars Karlitski 2015-02-18 23:42:56 UTC 
Created attachment 297233 [details] [review]
gapplication: test setting and binding busy state
Comment 5 Matthias Clasen 2015-02-19 01:10:46 UTC 
Review of attachment 297232 [details] [review]:

Makes sense.
Comment 6 Matthias Clasen 2015-02-19 01:11:35 UTC 
Review of attachment 297233 [details] [review]:

looks good
Comment 7 Allison Karlitskaya (desrt) 2015-02-19 01:46:43 UTC 
Looks good to me as well.  Thanks!
Comment 8 Lars Karlitski 2015-02-19 07:40:38 UTC 
Attachment 297232 [details] pushed as b4ef6d9 - gapplication: add "is-busy"
Attachment 297233 [details] pushed as 2b27382 - gapplication: test setting and binding busy state