After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744692 - Closed signal on notification prompt isn't handled
Closed signal on notification prompt isn't handled
Status: RESOLVED FIXED
Product: vino
Classification: Applications
Component: Server
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Vino Maintainer(s)
Vino Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-02-18 08:31 UTC by Ondrej Holy
Modified: 2015-02-18 09:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
handle closed signal properly on notification prompt (1.28 KB, patch)
2015-02-18 08:31 UTC, Ondrej Holy 		committed Details | Review

Description Ondrej Holy 2015-02-18 08:31:38 UTC 
Created attachment 297077 [details] [review]
handle closed signal properly on notification prompt

When the notification is closed (e.g. by close button), closed signal is emitted. This signal isn't handled currently and therefore vino-server is still waiting for response and block new notification from client (also doesn't close the connection).

So if you close the notification by mistake, you are not able to establish connection again until vino-server is restarted.

Downstream bugreport:
https://bugzilla.redhat.com/show_bug.cgi?id=1192548
Comment 1 David King 2015-02-18 09:18:42 UTC 
Review of attachment 297077 [details] [review]:

Looks fine, please push to master and gnome-3-14 after fixing the typo in the commit message ("therefor").
Comment 2 Ondrej Holy 2015-02-18 09:41:52 UTC 
Review of attachment 297077 [details] [review]:

Thanks for the review!

The patch with fixed commit messages was pushed to master and gnome-3-14 as:
commit aec3afbd79d0e21a8b2a7e47bea2fd46d0f8cad5
commit 5f8383f41cbcd7e9563ef67cf4a68e57f3f45b9c