GNOME Bugzilla – Bug 744689
hlssink: EXT-X-VERSION set to 6 while not using any features > 3
Last modified: 2015-08-08 11:51:58 UTC
The EXT-X-VERSION set in the playlists produced by hlssink is hardcoded to 6 , while as far as I can tell no feature for versions greater than 3 are in use [2,3].
VLC 2.1 only seems to support HLS up to version 3, and as per the spec  refuses to process playlists from an unsupported version, while it seems it supports all the features used by hlssink.
Would it be possible to reduce the version to 3, at least until features from the newer versions are used ?
Thanks for the great piece of software !
Yes, I think the version can indeed be 3 at this point.
agreed. Could you provide a patch in git format-patch format?
Created attachment 297265 [details] [review]
Here's the proposed change. Maybe would it be cleaner to factor out the version in a #define ?
Review of attachment 297265 [details] [review]:
Yes, please put it in a define to make clearer what the parameter is.
Created attachment 297273 [details] [review]
New version of the patch
Here it is. Not sure on the Gstreamer naming conventions though, and if placement is optimal (wondering if it should go to the gstm3u8playlist.h/c instead, and even if we shouldn't make that version field local to gstm3u8playlist.h/c at all (since the required version is entirely defined by the code of these files, I think)
Review of attachment 297273 [details] [review]:
Thanks for the update, looks good.
Thanks for the update, it was pushed to master.
For future patches, please add a commit message, even if minimum explaining the change. Also have indent installed on your system so that our git commit hooks detect if your code follows our coding style guidelines.
Author: Guillaume Seguin <email@example.com>
Date: Thu Feb 19 14:34:23 2015 +0100
hlssink: reduce playlist's EXT-X-VERSION to 3
We are not using any features greater than the 3rd version,
so reduce to what we actually use to make it compatible with
Thanks, and thanks for the hints, I'll sure do so next time.
Would it be possible to backport this to previous branches where the version was upped to 6?
The current git master has too many regressions to work practically, and so we are forced to use older branches of gstreamer.
What are the regressions in GIT master you're struggling with? Please report them so we can get them fixed.
Ive switched from v1.2 to 1.4, then master, than back to v1.4 in an effort to find a stable combination, and am still struggling. Once I get v1.4 to work I'll switch back to master and try that again.
Ok, please file bugs about anything broken you notice. 1.6 is planned to be released really soon now and it would be good to fix any regressions before that :)