After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744681 - Don't hardcode dim label style in list view
Don't hardcode dim label style in list view
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Views: List View
3.15.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-02-17 19:31 UTC by Cosimo Cecchi
Modified: 2015-02-18 21:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
list-view: use GdStyledRenderer (1.72 KB, patch)
2015-02-17 19:36 UTC, Cosimo Cecchi
none Details | Review
list-view: add a workaround for a GTK bug (1.33 KB, patch)
2015-02-17 19:36 UTC, Cosimo Cecchi
none Details | Review

Description Cosimo Cecchi 2015-02-17 19:31:06 UTC
In bug 744237 a hardcoded style for list view cell renderers was added. Instead, either GdStyledTextRenderer from libgd or a similar feature from GTK proper (see bug 676536) should be used.

Note that all these solutions, including the currently broken hardcode do not work because of bug 744397
Comment 1 Cosimo Cecchi 2015-02-17 19:36:10 UTC
Created attachment 297057 [details] [review]
list-view: use GdStyledRenderer
Comment 2 Cosimo Cecchi 2015-02-17 19:36:13 UTC
Created attachment 297058 [details] [review]
list-view: add a workaround for a GTK bug

Makes dim labels work correctly.
Comment 3 Carlos Soriano 2015-02-18 08:41:43 UTC
thanks for the correction. I guess is ok pushing this, or should we ask for an exception even if I merged previous code that was relying on a fix on Gtk+ side?
Comment 4 Cosimo Cecchi 2015-02-18 19:40:15 UTC
I would say a freeze exception should be asked just to be sure, since the UI changes with these patches.
Comment 5 Carlos Soriano 2015-02-18 21:15:28 UTC
UI freeze break allowed, thanks Cosimo!

Attachment 297057 [details] pushed as 02b9ec7 - list-view: use GdStyledRenderer
Attachment 297058 [details] pushed as a84f37a - list-view: add a workaround for a GTK bug