After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744658 - Playlists sidebar - border is cut off
Playlists sidebar - border is cut off
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
3.14.x
Other Linux
: Normal normal
: 3.16
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2015-02-17 12:36 UTC by Allan Day
Modified: 2015-08-09 09:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (26.57 KB, image/png)
2015-02-17 12:36 UTC, Allan Day 		  Details
Tweak sidebar ui (4.26 KB, patch)
2015-08-07 14:03 UTC, Trinh Anh Ngoc 		none Details | Review
Screenshot (110.02 KB, image/png)
2015-08-07 14:05 UTC, Trinh Anh Ngoc 		  Details
Tweak sidebar ui (4.26 KB, patch)
2015-08-07 14:14 UTC, Trinh Anh Ngoc 		none Details | Review
Tweak sidebar ui (4.69 KB, patch)
2015-08-08 15:33 UTC, Trinh Anh Ngoc 		none Details | Review
Screenshot (126.30 KB, image/png)
2015-08-08 15:34 UTC, Trinh Anh Ngoc 		  Details
Tweak sidebar ui (4.64 KB, patch)
2015-08-09 01:11 UTC, Trinh Anh Ngoc 		committed Details | Review

Description Allan Day 2015-02-17 12:36:26 UTC 
Created attachment 297017 [details]
screenshot

See the attached screenshot - the border is truncated.
Comment 1 Trinh Anh Ngoc 2015-08-07 14:03:14 UTC 
Created attachment 308899 [details] [review]
Tweak sidebar ui

Fix sidebar borders
Better sidebar background color
Comment 2 Trinh Anh Ngoc 2015-08-07 14:05:18 UTC 
Created attachment 308901 [details]
Screenshot
Comment 3 Trinh Anh Ngoc 2015-08-07 14:14:34 UTC 
Created attachment 308902 [details] [review]
Tweak sidebar ui

Fix rtl direction
Comment 4 Vadim Rutkovsky 2015-08-08 08:24:02 UTC 
Review of attachment 308902 [details] [review]:

Looks nice, but it doesn't really follow the mockup [1].

Some adjustments needs to be made:

1) Grey background for artists / playlists sidebar
2) Shadowed border on the right of the sidebar

[1] https://github.com/gnome-design-team/gnome-mockups/raw/master/music/music-artists.png
Comment 5 Trinh Anh Ngoc 2015-08-08 15:33:17 UTC 
Created attachment 308956 [details] [review]
Tweak sidebar ui

Ok. I made new patch for this.
Comment 6 Trinh Anh Ngoc 2015-08-08 15:34:42 UTC 
Created attachment 308957 [details]
Screenshot
Comment 7 Trinh Anh Ngoc 2015-08-09 01:11:30 UTC 
Created attachment 308964 [details] [review]
Tweak sidebar ui

Fix duplicate lines
Comment 8 Vadim Rutkovsky 2015-08-09 09:49:14 UTC 
Review of attachment 308964 [details] [review]:

Thanks! Pushed a slightly tweaked version:
master - https://git.gnome.org/browse/gnome-music/commit/?id=51dda34
gnome-3-16 - https://git.gnome.org/browse/gnome-music/commit/?id=17c33c7