GNOME Bugzilla – Bug 744642
Screen recorder timestamps buffers incorrectly, breaking A/V sync
Last modified: 2015-02-19 08:20:32 UTC
Created attachment 296988 [details] [review] 0001-shell-recorder-Timestamp-buffers-from-the-pipeline-c.patch Currently the screen recorder puts wrong timestamps on buffers. It just uses the wall clock, while it should use the pipeline clock as it's even written in one of the comments there. This causes e.g. A/V sync to be completely off if you add an audio branch to the pipeline as alexl noticed. Attached patch fixes that.
Created attachment 296989 [details] Example app to test audio sync Here is a small gjs app that uses the screencast dbus API to record audio+video together. Without the patch the audio is off by ~2 sec for me.
Review of attachment 296988 [details] [review]: Make sense.
Ok, thanks! Pushed the commit :) commit c4a775e94a8f4c22bca85289e37ee468916bde40 Author: Sebastian Dröge <sebastian@centricular.com> Date: Tue Feb 17 10:16:44 2015 +0200 shell-recorder: Timestamp buffers from the pipeline clock, not the wall clock This should give more accurate timestamps on the video buffers, and especially keep A/V sync when audio is also recorded. https://bugzilla.gnome.org/show_bug.cgi?id=744642