After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744624 - XML_XINCLUDE_START attributes not preserved (w/patch)
XML_XINCLUDE_START attributes not preserved (w/patch)
Status: RESOLVED OBSOLETE
Product: libxml2
Classification: Platform
Component: xinclude
git master
Other Linux
: Normal normal
: ---
Assigned To: Daniel Veillard
libxml QA maintainers
Depends on:
Blocks:
 
 
Reported: 2015-02-16 20:19 UTC by Christoph Elsenhans
Modified: 2021-07-05 13:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed fix (901 bytes, patch)
2015-02-16 20:19 UTC, Christoph Elsenhans
none Details | Review
attribute-related functions for xinclude nodes (1.96 KB, patch)
2015-02-16 20:21 UTC, Christoph Elsenhans
none Details | Review

Description Christoph Elsenhans 2015-02-16 20:19:57 UTC
Created attachment 296977 [details] [review]
proposed fix

Changeset 3e62adbe39f2083c9c2cd3330c320227818fd361
"Adding various checks on node type though the API"
reintroduces bug #407389: When subtrees are cloned, XML_XINCLUDE_START nodes lose their href and xpointer attributes. Since cloning is also used by xmlXIncludeLoadDoc, all nested xincludes have no href or xpointer attributes after parsing.

Attached diff
copy_xinclude_props.diff
fixes this regression.


Also attached is
get_xinclude_props.diff
which enables various attribute-related functions (like xmlHasProp) to also operate on XML_XINCLUDE_START nodes. But this is actually unrelated to the bug, and only a feature suggestion :)
Comment 1 Christoph Elsenhans 2015-02-16 20:21:20 UTC
Created attachment 296978 [details] [review]
attribute-related functions for xinclude nodes

second attachment
Comment 2 GNOME Infrastructure Team 2021-07-05 13:23:54 UTC
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version, then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a new ticket at
  https://gitlab.gnome.org/GNOME/libxml2/-/issues/

Thank you for your understanding and your help.