After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744576 - lint bugzilla module and node defs
lint bugzilla module and node defs
Status: RESOLVED FIXED
Product: sysadmin
Classification: Infrastructure
Component: Apprentices
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Sysadmins
GNOME Sysadmins
Depends on:
Blocks:
 
 
Reported: 2015-02-15 22:45 UTC by matanya
Modified: 2015-04-07 15:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
lint bugzilla patch (12.26 KB, patch)
2015-02-15 22:45 UTC, matanya 		needs-work Details | Review
node def patch (340 bytes, patch)
2015-02-15 22:51 UTC, matanya 		needs-work Details | Review

Description matanya 2015-02-15 22:45:06 UTC 
Created attachment 296896 [details] [review]
lint bugzilla patch

This lint fixes the bugzilla module and node.
Comment 1 matanya 2015-02-15 22:51:08 UTC 
Created attachment 296897 [details] [review]
node def patch
Comment 2 Andrea Veri 2015-02-17 11:55:47 UTC 
Review of attachment 296896 [details] [review]:

The patch does not apply. Please make sure to pull the very latest changes on that module and recreate the patch.
Comment 3 Andrea Veri 2015-02-17 11:56:44 UTC 
Review of attachment 296897 [details] [review]:

This patch is actually wrong as you've specified the class name as bugzilla and then include bugzilla::web-server again.
Comment 4 matanya 2015-02-17 12:42:40 UTC 
I just wrote the diff command for the second patch wrong :/
Comment 5 Andrea Veri 2015-04-07 15:28:24 UTC 
I reworked the patch a bit and merged it. Thanks!