After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744562 - Allow insert of emoticons in plain text mode
Allow insert of emoticons in plain text mode
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Composer
3.14.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Tomas Popela
Evolution QA team
Depends on: 740169
Blocks:
 
 
Reported: 2015-02-15 16:30 UTC by Jonas Hahnfeld
Modified: 2015-02-18 18:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Pretty simple patch (3.06 KB, patch)
2015-02-15 17:16 UTC, Jonas Hahnfeld 		committed Details | Review

Description Jonas Hahnfeld 2015-02-15 16:30:34 UTC 
With Unicode smileys, we should allow the usage of emoticons in plain text mode.

To be discussed: Should the textual representation be translated to the Unicode character when enabled? My opinion: Yes!
Comment 1 Jonas Hahnfeld 2015-02-15 17:16:31 UTC 
Created attachment 296884 [details] [review]
Pretty simple patch

Enables the button for plain text mode
Takes care that inserting emoticons is correctly working in text mode (with switching to the image when switching to HTML mode)
Enables magic smileys for text mode
Comment 2 Milan Crha 2015-02-17 14:41:38 UTC 
Review of attachment 296884 [details] [review]:

Thanks for the patch. It looks fine. Let's commit it if the release-team will approve.
Comment 3 Milan Crha 2015-02-18 18:06:08 UTC 
I received an approve, thus I committed this to sources. I also filled bug #744734 to document this in user documentation.

Created commit 2aee680 in evo master (3.13.91+)