After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744505 - gedit/gedit-notebook.h is in gedit_NOINST_H_FILES while gedit/gedit-commands.h is in gedit_INST_H_FILES
gedit/gedit-notebook.h is in gedit_NOINST_H_FILES while gedit/gedit-commands....
Status: RESOLVED FIXED
Product: gedit
Classification: Applications
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2015-02-14 00:56 UTC by Kyrylo V. Polezhaiev
Modified: 2015-02-21 13:24 UTC
See Also:
GNOME target: ---
GNOME version: 3.13/3.14


Description Kyrylo V. Polezhaiev 2015-02-14 00:56:24 UTC 
I use /* gedit.vapi generated by vapigen-0.26, do not modify. */ from vala-gedit-devel-3.14.0-1.5.x86_64 for OpenSUSE 13.2 but it requires gedit/gedit-notebook.h to be installed. However, there is no such header in this package.
Comment 1 Kyrylo V. Polezhaiev 2015-02-14 01:02:19 UTC 
Strange:
rpm -ql gedit-devel-3.14.0-1.5.x86_64
/usr/include/gedit-3.12
/usr/include/gedit-3.12/gedit
/usr/include/gedit-3.12/gedit/gedit-app-activatable.h
/usr/include/gedit-3.12/gedit/gedit-app.h
/usr/include/gedit-3.12/gedit/gedit-commands.h
/usr/include/gedit-3.12/gedit/gedit-debug.h
/usr/include/gedit-3.12/gedit/gedit-document.h
/usr/include/gedit-3.12/gedit/gedit-encodings-combo-box.h
/usr/include/gedit-3.12/gedit/gedit-menu-extension.h
/usr/include/gedit-3.12/gedit/gedit-message-bus.h
/usr/include/gedit-3.12/gedit/gedit-message.h
/usr/include/gedit-3.12/gedit/gedit-progress-info-bar.h
/usr/include/gedit-3.12/gedit/gedit-statusbar.h
/usr/include/gedit-3.12/gedit/gedit-tab.h
/usr/include/gedit-3.12/gedit/gedit-utils.h
/usr/include/gedit-3.12/gedit/gedit-view-activatable.h
/usr/include/gedit-3.12/gedit/gedit-view.h
/usr/include/gedit-3.12/gedit/gedit-window-activatable.h
/usr/include/gedit-3.12/gedit/gedit-window.h
...

This package has 3.12 files inside, may be some packaging error by OpenSUSE team?
Comment 2 Kyrylo V. Polezhaiev 2015-02-14 11:53:00 UTC 
It looks like gedit/gedit-notebook.h is present in gedit_NOINST_H_FILES but gedit/gedit-commands.h which is gedit_INST_H_FILES includes it.
Comment 3 Kyrylo V. Polezhaiev 2015-02-14 12:18:41 UTC 
However, I can see it here:

gedit_ENUM_TYPES = 		\
	gedit/gedit-notebook.h	\
	$(gedit_INST_H_FILES)

Unfortunately this bug prevents Valencia plugin written in Vala from build. Should we add gedit/gedit-notebook.h to gedit_INST_H_FILES?
Comment 4 Sébastien Wilmet 2015-02-16 19:26:20 UTC 
(In reply to Kyrylo V. Polezhaiev from comment #1)
> Strange:
> rpm -ql gedit-devel-3.14.0-1.5.x86_64
> /usr/include/gedit-3.12

> This package has 3.12 files inside, may be some packaging error by OpenSUSE
> team?

No, it's the gedit API version, so usually it's normal that it's not the same version, but here we forgot to update it to 3.14 since the 3.14 version breaks the API.
Comment 5 Kyrylo V. Polezhaiev 2015-02-16 21:38:12 UTC 
Hello Sebastien,

So, do we need to add gedit/gedit-notebook.h to gedit_INST_H_FILES?
Comment 6 Sébastien Wilmet 2015-02-21 12:24:34 UTC 
gedit-notebook.h has been included in gedit-commands.h in commit 3217dbaba787681de39097c73962801c712b781c, but it was an error. gedit-notebook should remain private.
Comment 7 Kyrylo V. Polezhaiev 2015-02-21 12:45:56 UTC 
So maybe let's just remove it from gedit-commands.h together with _gedit_cmd_file_close_notebook?
Comment 8 Paolo Borelli 2015-02-21 13:24:27 UTC 
This should now be fixed, I split a gedit-commands-private.h header