After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744503 - wrong usage of gdk_property_get() (once again)
wrong usage of gdk_property_get() (once again)
Status: RESOLVED FIXED
Product: seahorse
Classification: Applications
Component: general
3.14.x
Other Solaris
: Normal normal
: ---
Assigned To: Seahorse Maintainer
Seahorse Maintainer
Depends on:
Blocks:
 
 
Reported: 2015-02-14 00:37 UTC by Alexander Pyhalov
Modified: 2015-07-14 19:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
seahorse-key-manager-store.c.patch (737 bytes, patch)
2015-02-14 00:37 UTC, Alexander Pyhalov 		none Details | Review
Fix wrong usage of gdk_property_get() (1.19 KB, patch)
2015-07-14 19:42 UTC, Stef Walter 		none Details | Review

Description Alexander Pyhalov 2015-02-14 00:37:14 UTC 
Created attachment 296811 [details] [review]
seahorse-key-manager-store.c.patch

During fixing error in file-roller (https://bugzilla.gnome.org/show_bug.cgi?id=479351), I've found similar code in seahorse. In seahorse-3.14.0/libseahorse/seahorse-key-manager-store.c function gdk_property_get is used. However, the actual length of the answer is not checked, so it can return garbage on the end of the string. 
Patch, fixing this behavior is attached.
Comment 1 Stef Walter 2015-07-14 19:42:32 UTC 
Created attachment 307429 [details] [review]
Fix wrong usage of gdk_property_get()
Comment 2 Stef Walter 2015-07-14 19:43:02 UTC 
Attachment 307429 [details] pushed as a81db53 - Fix wrong usage of gdk_property_get()