After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744487 - HighContrast icons
HighContrast icons
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-02-13 19:31 UTC by Arnaud B.
Modified: 2015-04-16 19:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
icon: provide a symbolic variant of the app icon (9.23 KB, patch)
2015-04-09 23:27 UTC, Jakub Steiner
none Details | Review

Description Arnaud B. 2015-02-13 19:31:50 UTC
Builder should provide a HighContrast icon, as detailed on the wiki[1].

[1] https://wiki.gnome.org/Initiatives/GnomeGoals/HighContrastAppIcons
Comment 1 Matthias Clasen 2015-02-15 20:07:08 UTC
The way this works nowadays is that applications are expected to provide a symbolic version of their app icon, preferably as .symbolic.png. The HighContrast theme picks these up automatically.
Comment 2 Christian Hergert 2015-02-15 20:14:06 UTC
Maybe if we are lucky, Jakub has some cycles to create a symbolic variant?
Comment 3 Jakub Steiner 2015-04-09 23:27:28 UTC
Created attachment 301242 [details] [review]
icon: provide a symbolic variant of the app icon

Since 3.16 the high contrast accessible theme is
covered by the recolorable symbolic variant of the app icon.

The symbolic size has been introduced to hicolor to cope with
the nominal size of 16x16 rather than the backward compatible
128x128.

Some of the publically installed icons actually belong to the local
resource too.
Comment 4 Christian Hergert 2015-04-10 02:13:12 UTC
Pushed to master.

I had to remove the "icon-name" specified in the various Windows for the symbolic icon to show up. I guess it doesn't automatically take the variant if specified.

That means that icons look wrong unless you've installed it to --prefix=/usr or are running a jhbuild shell.

There is probably something that can be done about it, but I'm not up to date.
Comment 5 Alexandre Franke 2015-04-16 19:04:56 UTC
(In reply to Christian Hergert from comment #4)
> That means that icons look wrong unless you've installed it to --prefix=/usr
> or are running a jhbuild shell.
> 
> There is probably something that can be done about it, but I'm not up to
> date.

Good enough for now. If that really needs to be solved, a new report can be opened about it.