After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744460 - Make backup's module puppet-lint compliant
Make backup's module puppet-lint compliant
Status: RESOLVED FIXED
Product: sysadmin
Classification: Infrastructure
Component: Apprentices
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Sysadmins
GNOME Sysadmins
Depends on:
Blocks:
 
 
Reported: 2015-02-13 10:25 UTC by Daniel Mustieles
Modified: 2015-05-04 11:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
puppet-lint fixes to backup (2.62 KB, patch)
2015-02-13 10:25 UTC, Daniel Mustieles 		accepted-commit_now Details | Review
Patch fixed (2.49 KB, patch)
2015-02-13 16:44 UTC, Daniel Mustieles 		committed Details | Review

Description Daniel Mustieles 2015-02-13 10:25:04 UTC 
Created attachment 296759 [details] [review]
puppet-lint fixes to backup

Patch to fix backup's init.pp file, to make it pass lint checks
Comment 1 Olav Vitters 2015-02-13 10:29:54 UTC 
The intending is a little bit weird, no? Package is not at the same level as file. Is this intentional?
Comment 2 Olav Vitters 2015-02-13 10:37:02 UTC 
Review of attachment 296759 [details] [review]:

Commit with maybe aligned indentation.
Comment 3 Daniel Mustieles 2015-02-13 16:44:45 UTC 
Created attachment 296787 [details] [review]
Patch fixed

My fail. Here is a fixed patch. Hope now it ok
Comment 4 Andrea Veri 2015-02-16 16:05:10 UTC 
Merged.

Thanks!
Comment 5 matanya 2015-05-04 11:12:44 UTC 
follow up patch in Bug 748881