After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744454 - build fails using jhbuild
build fails using jhbuild
Status: RESOLVED FIXED
Product: yelp
Classification: Applications
Component: General
3.14.x
Other Linux
: Normal normal
: ---
Assigned To: Yelp maintainers
Yelp maintainers
: 744342 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-02-13 07:46 UTC by Marek Chalupa
Modified: 2015-02-16 08:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
check if __STDC_VERSION__ is defined (1.62 KB, patch)
2015-02-13 07:46 UTC, Marek Chalupa 		committed Details | Review

Description Marek Chalupa 2015-02-13 07:46:13 UTC 
Created attachment 296749 [details] [review]
check if __STDC_VERSION__ is defined

Trying to build yelp with jhbuild yields this error:

yelp-debug.h:38:5: error: "__STDC_VERSION__" is not defined [-Werror=undef]
 #if __STDC_VERSION__ < 199901L

Attached patch adds check if this macro is defined. If it is not, then the standard is < 199901, so the intended behavior of original #if holds.
Comment 1 David King 2015-02-14 10:36:28 UTC 
*** Bug 744342 has been marked as a duplicate of this bug. ***
Comment 2 David King 2015-02-14 10:41:01 UTC 
Review of attachment 296749 [details] [review]:

GNOME does not generally do Signed-off-by: in the commit message. Commit looks fine, and builds fine for me with GCC 5, so please push (if you have commit access). If not, I can push on your behalf.
Comment 3 Marek Chalupa 2015-02-16 07:05:16 UTC 
I do not have commit access, so please push it. Feel free to remove the Signed-off-by. Or do you want me to post new patch without it?
Comment 4 David King 2015-02-16 08:24:50 UTC 
Review of attachment 296749 [details] [review]:

Pushed to master as 9ccbe9df9df30341e2c92e2b1a8fada65832d6ca. I amended the commit message to drop the signed-off-by, and add a link to this bug report. Thanks again!