After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744448 - The compress function works abnormal for trash, disk and so on.
The compress function works abnormal for trash, disk and so on.
Status: RESOLVED OBSOLETE
Product: file-roller
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: file-roller-maint
file-roller-maint
Depends on:
Blocks:
 
 
Reported: 2015-02-13 01:36 UTC by lenky0401
Modified: 2020-11-11 19:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Hidden the compress item when user right click the trash or disk drive on the desktop (949 bytes, patch)
2015-02-13 01:36 UTC, lenky0401
needs-work Details | Review

Description lenky0401 2015-02-13 01:36:44 UTC
Created attachment 296731 [details] [review]
Hidden the compress item when user right click the trash or disk drive on the desktop

OS: Ubuntu 14.10

Steps:
1. Login system
2. Right click the trash or disk drive on the desktop
3. Chose compress
4. Click "OK" button
5. After compress successfully, check the gz file
    -->Failed. There is no gz file found.


PS: 
Original bug reported is here: 
https://bugs.launchpad.net/ubuntukylin/+bug/1403377

thx.
Comment 1 Iain Lane 2015-03-02 17:12:37 UTC
Comment on attachment 296731 [details] [review]
Hidden the compress item when user right click the trash or disk drive on the desktop

I don't know about the soundness of the logic (that's for a maintainer), but ...

>@@ -287,8 +287,10 @@ nautilus_fr_get_file_items (NautilusMenuProvider *provider,
> 	if (files == NULL)
> 		return NULL;
> 
>-	if (unsupported_scheme ((NautilusFileInfo *) files->data))
>-		return NULL;
>+	for (scan = files; scan; scan = scan->next) {
>+	    if (unsupported_scheme ((NautilusFileInfo *) scan->data))
>+		    return NULL;
>+	}
> 
> 	for (scan = files; scan; scan = scan->next) {
> 		NautilusFileInfo *file = scan->data;

Merge this into next loop.
Comment 2 Paolo Bacchilega 2015-03-02 18:09:28 UTC
This should be fixed with commit d7c57598602cfe81874f4f20b48ea92a81932379
Comment 3 André Klapper 2020-11-11 19:13:35 UTC
bugzilla.gnome.org is being replaced by gitlab.gnome.org. We are closing all old bug reports and feature requests in GNOME Bugzilla which have not seen updates for a long time.

If you still use file-roller and if you still see this bug / want this feature in a currently supported version of GNOME (currently that would be 3.38), then please feel free to report it at https://gitlab.gnome.org/GNOME/file-roller/-/issues/

Thank you for creating this report and we are sorry it could not be implemented (volunteer workforce and time is limited).