GNOME Bugzilla – Bug 744384
Make damnedlies's init file puppet-compliant
Last modified: 2015-02-22 18:44:16 UTC
Created attachment 296669 [details] [review] Damnedlies puppet-lint compliant Fixed syntax damnedlies/manifests/init.pp according to puppet-lint checks. Don't know why file's mode has been changed when creating the patch... if it's wrong, and I have to change it before commiting, let me know to fix the patch and re-attatch it to the bug. Thanks!
A nicer way would be to indent the entire package list one more indent, and have the ensure => line right under in a new line.
Created attachment 296670 [details] [review] Patch updated
The problem when adding one more indent is that lint shows a warning: ERROR: two-space soft tabs not used on line 4 ERROR: two-space soft tabs not used on line 5 The ensure => has no problem to be in a newline.
are you using tabs or spaces?
Spaces... tab character seems to not be allowed: ERROR: tab character found on line 3 ERROR: tab character found on line 4
Created attachment 296674 [details] what i mean attached is how i think it should look like.
Created attachment 296675 [details] [review] Patch updated It works perfectly :) Here is the patch updated. Thanks!
Great! one last nitpick, on lines 31-32, the user and group should be in 'gnomeweb' Other than that, +1 here.
Created attachment 296676 [details] [review] Final patch ;-) Good! here is the latest version. Thanks!
excellent. Now =, since we don't have a policy I can't enforce one way of style, but once we have, my preference is every resource block ends with a comma and no use of colons at all. Sysadmins, what do you say, high time for a policy ? :)
I've created a list of modules than doesn't complain with lint. If you agree, we could open a new bug with that list, so everyone who wants to fix them can easyly do it without overlapping work with other apprentices (just announcing you're going to fix modules A and B should be enough). Patches for each module should be in different bugs, to avoid overwhelming the one containing the list. What do you think?
that is a good idea. Go for it. The only shortcoming is as the tree changes new issues will be introduced and old one will go, but we can deal with that later.
Comment on attachment 296676 [details] [review] Final patch ;-) Patch committed to master branch. Thanks!
(In reply to Daniel Mustieles from comment #0) > Don't know why file's mode has been changed when creating the patch... because of copying the repository. I've updated the wiki to show "cp -ar" to preserve modes.