After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744380 - programming-guidelines: Add a page on GMainContext
programming-guidelines: Add a page on GMainContext
Status: RESOLVED FIXED
Product: gnome-devel-docs
Classification: Applications
Component: programming-guidelines
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Devel docs: Programming Guidelines maintainer(s)
gnome-devel-docs maintainers
Depends on:
Blocks:
 
 
Reported: 2015-02-12 09:58 UTC by Philip Withnall
Modified: 2015-02-12 12:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
programming-guidelines: Add a page on GMainContext (41.44 KB, patch)
2015-02-12 09:58 UTC, Philip Withnall
committed Details | Review

Description Philip Withnall 2015-02-12 09:58:19 UTC
This is effectively a conversion of my blog posts from https://tecnocode.co.uk/tag/gmaincontext/ to Mallard, with some rearranging. I’m not entirely sure about the section structuring (or titles), so some scrutiny on those in the review would be appreciated.
Comment 1 Philip Withnall 2015-02-12 09:58:23 UTC
Created attachment 296663 [details] [review]
programming-guidelines: Add a page on GMainContext

Link it in to the page on threading too.
Comment 2 David King 2015-02-12 10:24:00 UTC
Review of attachment 296663 [details] [review]:

Looks good!

::: programming-guidelines/C/main-contexts.page
@@ +76,3 @@
+      (such as GTK+). It is at the core of almost every GLib application. To
+      understand <code>GMainContext</code> requires understanding
+      <link href="http://man7.org/linux/man-pages/man2/poll.2.html">poll()</link>

Locally, this can be "man:poll(2)", but this probably works poorly on developer.gnome.org.

@@ +148,3 @@
+      the array of FDs to pass to <code>poll()</code>, especially when operating
+      over multiple threads. This is done by encapsulating FDs in
+      <code>GSource</code>s, which decide whether those FDs should be passed to

"decides"?
Comment 3 Philip Withnall 2015-02-12 12:06:29 UTC
Merged with the man link change (it doesn’t generate a different URI when building HTML, but I think this is something which should be addressed in yelp-build).

The second change is incorrect: ‘decide’ refers to the ‘GSources’ (plural).

Attachment 296663 [details] pushed as 46441cd - programming-guidelines: Add a page on GMainContext
Comment 4 David King 2015-02-12 12:10:00 UTC
Oh, I completely missed the trailing 's'. Thanks!
Comment 5 Philip Withnall 2015-02-12 12:12:52 UTC
(In reply to Philip Withnall from comment #3)
> Merged with the man link change (it doesn’t generate a different URI when
> building HTML, but I think this is something which should be addressed in
> yelp-build).

=> Bug #744389