After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744332 - fingerprint enrollment should get disabled when org.gnome.login-screen enable-fingerprint-authentication is false
fingerprint enrollment should get disabled when org.gnome.login-screen enable...
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: User Accounts
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Ondrej Holy
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-02-11 15:31 UTC by Ray Strode [halfline]
Modified: 2015-02-23 11:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
don't show fingerprint options if disabled (2.42 KB, patch)
2015-02-23 11:12 UTC, Ondrej Holy
committed Details | Review

Description Ray Strode [halfline] 2015-02-11 15:31:33 UTC
if the administrator disabled fingerprint authentication, then we shouldn't show it in the UI.

This is controlled by org.gnome.login-screen enable-fingerprint-authentication
Comment 1 Bastien Nocera 2015-02-11 15:40:54 UTC
(In reply to Ray Strode [halfline] from comment #0)
> if the administrator disabled fingerprint authentication, then we shouldn't
> show it in the UI.
> 
> This is controlled by org.gnome.login-screen
> enable-fingerprint-authentication

That doesn't propagate to the user.
Comment 2 Ray Strode [halfline] 2015-02-11 17:04:07 UTC
hmm, two choices (I guess):

1) set DCONF_PROFILE=gdm and do:
 GSettingsBackend *backend = g_object_new (g_type_from_name ("DConfSettingsBackend", ...);
 g_settings_new_with_backend (...,backend);  
2) use dconf_engine_new directly with "gdm" as the first argument

2 seems better to me, but we should ask Ryan what he thinks is the right way forward.
Comment 3 Allison Karlitskaya (desrt) 2015-02-20 14:46:58 UTC
Given your constraints, 2.

But this is very weird...
Comment 4 Bastien Nocera 2015-02-20 16:19:14 UTC
(In reply to Ryan Lortie (desrt) from comment #3)
> Given your constraints, 2.
> 
> But this is very weird...

That's not an exported function... Could gdm export that information through D-Bus instead?
Comment 5 Ray Strode [halfline] 2015-02-20 17:43:08 UTC
wait a minute, we're confused. it does propagate to the user. admin isn't supposed to set it in the gdm profile, but the user profile.

see here:

https://help.gnome.org/admin/system-admin-guide/stable/login-fingerprint.html.en
Comment 6 Ondrej Holy 2015-02-23 11:12:27 UTC
Created attachment 297631 [details] [review]
don't show fingerprint options if disabled
Comment 7 Bastien Nocera 2015-02-23 11:31:56 UTC
Review of attachment 297631 [details] [review]:

Looks good.
Comment 8 Ondrej Holy 2015-02-23 11:58:41 UTC
Comment on attachment 297631 [details] [review]
don't show fingerprint options if disabled

commit de821d592294de94659b316792a1395fd08352bb