After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744296 - Fix format string signedness warnings
Fix format string signedness warnings
Status: RESOLVED FIXED
Product: gnome-disk-utility
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-disk-utility-maint
gnome-disk-utility-maint
Depends on:
Blocks:
 
 
Reported: 2015-02-10 23:03 UTC by David King
Modified: 2015-03-26 18:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (6.69 KB, patch)
2015-02-10 23:04 UTC, David King 		committed Details | Review

Description David King 2015-02-10 23:03:40 UTC 
GCC 5.0, with its new -Wformat-signedness, warns about the sign being different between a type and the format string in printf-format messages, and udisks enables -Wformat=2 as part of its default warnings (which eventually causes the build to fail).
Comment 1 David King 2015-02-10 23:04:34 UTC 
Created attachment 296549 [details] [review]
proposed patch

Fixes the build for me.
Comment 2 Michael Catanzaro 2015-03-26 14:38:28 UTC 
Thanks!
Comment 3 Alexandre Franke 2015-03-26 14:44:03 UTC 
Hey Michael, thanks for committing this. The commit however broke the string freeze. Can you please branch for gnome-3-16 before this commit?
Comment 4 Michael Catanzaro 2015-03-26 18:14:06 UTC 
Yes, sorry about that.