After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744289 - [PATCH] Use Gtk.Stack instead of Gtk.Notebook in LibraryWindow
[PATCH] Use Gtk.Stack instead of Gtk.Notebook in LibraryWindow
Status: RESOLVED FIXED
Product: shotwell
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: 0.24
Assigned To: Shotwell Maintainers
Shotwell Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-02-10 20:57 UTC by Wolfgang Steitz
Modified: 2016-05-29 14:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch that implements this. (4.83 KB, patch)
2015-02-10 20:57 UTC, Wolfgang Steitz 		none Details | Review
updated patch to current master (4.37 KB, patch)
2016-05-23 20:45 UTC, Wolfgang Steitz 		committed Details | Review

Description Wolfgang Steitz 2015-02-10 20:57:22 UTC 
Created attachment 296540 [details] [review]
Patch that implements this.

With the attached patch, the Library window is using a Gtk.Stack to hold the pages instead of a Gtk.Notebook.
Comment 1 Jim Nelson 2015-02-10 22:33:39 UTC 
Thanks!

Pushed to master, commit be4dc3
Comment 2 Wolfgang Steitz 2015-02-11 21:51:45 UTC 
Using a Gtk.Stack seemed to be a good idea, but when trying to edit an image something is going wrong. Not sure how to fix that, maybe just revert this. Sorry.
Comment 3 Jim Nelson 2015-02-11 23:50:37 UTC 
I see it to.  Reverted in master, commit e21982.
Comment 4 Jens Georg 2016-05-21 18:19:40 UTC 
Can anyone elaborate what exactly is wrong?
Comment 5 Wolfgang Steitz 2016-05-23 20:44:21 UTC 
If I remember correctly, some of the pages didn't show correctly when selecting them and there was some flickering. There was obviously something wrong. I just tried it again with the current master, and it seems to work just fine. Eventually related to a newer GTK version.
Comment 6 Wolfgang Steitz 2016-05-23 20:45:14 UTC 
Created attachment 328407 [details] [review]
updated patch to current master