Created attachment 296520 [details] [review]
power: Use the backlight helper on Linux unconditionally

Review of attachment 296520 [details] [review]:

::: plugins/power/gpm-common.c
@@ +562,3 @@
         }
+        return -1;
+#endif

#else ?

@@ +582,3 @@
         }
+        return value;
+#endif

#else again?

@@ +626,3 @@
         }
+        return ret;
+#endif

Ditto.

@@ +677,3 @@
         }
+        return percentage_value;
+#endif

Ditto.

@@ +732,3 @@
         }
+        return percentage_value;
+#endif

Ditto.

@@ +762,3 @@
                 return gnome_rr_output_set_backlight (output, value, error);
+        return ret;
+#endif

Ditto.

Created attachment 296947 [details] [review]
power: Use the backlight helper on Linux unconditionally

--
Switched to #else ... #endif

Review of attachment 296947 [details] [review]:

Fine by me.

Attachment 296947 [details] pushed as dbd3b13 - power: Use the backlight helper on Linux unconditionally